Building from Source broken (master)

[Bernd-Christian Renner]

I am running GC on a recent Macbook Air and compiled myself, as I do not want to install Rosetta. However, the current master branch and tag v3.7-DEV2412 seem to be broken due to issues in src/Gui/Pages.cpp:

- inclusion of ActionButtonBox.h is missing

- method ProcessorPage::processorSelected uses undefined variable actionButtons 

[Ale Martinez]

It’s weird since ci build on macOS completed successfully:  https://app.travis-ci.com/github/GoldenCheetah/GoldenCheetah/jobs/629041216

[Joachim Kohlhammer]

Can you please check the following:

1. Are the files src/Gui/ActionButtonBox.cpp and src/Gui/ActionButtonBox.h present in your tree?
   
2. Are the files listed in your src/src.pro (lines 673 and 782)
3. Did you re-run qmake -r?

[Ale Martinez]

I could reproduce the issue, Joachim, problem happens when you build without enabling Python embedding:

Declaration is conditional:

https://github.com/GoldenCheetah/GoldenCheetah/blob/9e38ae9b85e325944b0b49d2655c8ee9358ad39a/src/Gui/Pages.h#L544-L547

but usage is unconditional:

https://github.com/GoldenCheetah/GoldenCheetah/blob/9e38ae9b85e325944b0b49d2655c8ee9358ad39a/src/Gui/Pages.cpp#L2713-L2716 

[Joachim Kohlhammer]

Good catch, will fix it

[Bernd-Christian Renner]

Thanks for looking into this. I am compiling a relatively raw configuration (I have Strava enabled, but that's it), and I didn't check all the ifdefs. What I am seeing is that

1. ActionButtonBox.h isn't included in Pages.cpp (not directly, and probably not indirectly through another header due to some ifdef)

2. When I add it directly (via include), actionButtons are not defined in the file Pages.cpp (src/Gui): https://github.com/GoldenCheetah/GoldenCheetah/blob/master/src/Gui/Pages.cpp

[Joachim Kohlhammer]

Created https://github.com/GoldenCheetah/GoldenCheetah/pull/4585

[Ale Martinez]

El lunes, 23 de diciembre de 2024 a la(s) 4:13:01 p.m. UTC-3, Joachim Kohlhammer escribió:

Created https://github.com/GoldenCheetah/GoldenCheetah/pull/4585

Merged, thank you, I works in my macOS Sonoma using Qt 6.7.3 without Python now. 

To the OP,: git pull origin (or upstream if you forked) master should fix the issue.

[Bernd-Christian Renner]

Waited for make to complete before confirmation: all is fine now. :-) Thank you.