I'm thinking trends is about analysis of completed/past activities and long term metrics, while plan view is about planning future activities, comparing completed activities against the planned training programme. It would be the place to create/edit future activities/training plans, load/save, etc. I'm not sure what metrics would be useful for planned against completed activity comparisons. The "Planning Calendar" would be the main chart within plan view, and only available in plan view.
* when the calendar is used as default view and is opened immediately
after program start, new activities autoimported in the background only
appear after switching to another view.
For me it would be convenient if a successful autoimport would refresh
the calendar automatically.
After an initial look at the plan view (PR #4690), I want to share my impressions (user standpoint only, no code review):
- Overall I liked the solution, some refinements could improve the UX.
- Seasons work as expected: Switching in plan view reflects in trends and the other way round
- Forward / backward buttons work as expected
- Sidebar / Charts pane: Is it possible to hide the charts? They don't make sense to me in the plan view
- Toolbar: Currently plan view has no compare pane available, is it possible to disable the toggle action?
Lets start a discussion about trends and plan view. What is the purpose of each, how do they differ, which charts should be available? Based on those results it will be clearer for everybody what to expect where.
Additional proposals (possible tasks for me):
- "Planning Calendar" should be renamed to just "Calendar". I added the planning-attribute as the old calendar still was around when I started
- Agenda should be moved out of the calendar chart into its own. Calendar fits IMHO to both trends and plan, agenda only to plan. The refactoring and code duplication shouldn't be too bad and I would prefer it this way from a users perspective
- Should the current season be shown in the header of the calendar (similar to the agenda)? This would make clearer what the users sees and interacts with while saving the space for the sidebar
The auto import not updating the calendar is probably due to the import containing more than 20 activities ( Poncho can you confirm this is the issue? or provide more information on how to repeat the issue? ) , as I have tested it with fewer activities and it updates fine, as each activity is added it is updated in the calendar
The issue is trying to import >20 activities, which RideImportWizard.cpp considers to be a batch import and then it doesn't signal in the RideCache that a ride has been added, see https://github.com/GoldenCheetah/GoldenCheetah/blob/a7200a31ff54f1f8a9cc8bf765fe699a02654638/src/Gui/RideImportWizard.cpp#L1121 and https://github.com/GoldenCheetah/GoldenCheetah/blob/a7200a31ff54f1f8a9cc8bf765fe699a02654638/src/Core/RideCache.cpp#L302I have created commit that will add a signal when the ride import is complete and used this to refresh the calendar, it works fine, I can it to the plan view work once Poncho has confirmed this is actually the issue.
I'm not sure why the PMC chart should cause any left sidebar issues, but I have corrected the LTM sidebar status displayed in the View menu and updated its status on change:
https://github.com/GoldenCheetah/GoldenCheetah/pull/4690/commits/3ed4442e505e49443eb4366e73f489e300f51c1c
If it still occurs, can you explain the steps to repeat it?
Please see (and test) the following commit which removes the user chart trends-plan view switching: https://github.com/GoldenCheetah/GoldenCheetah/pull/4690/commits/c4bf7485f97b6798340ad350d2318db74923106f


Hello Joachim, one small detail I noticed:
Would it be possible to include a checkbox to classify an activity as a non-activity, for example for recovery time, in order to follow a precise plan. thank you!
Pat
Hi Ale,
Unless I'm mistaken in my tests, "recovery time" is always counted in activities.