[Golden Cheetah - Feature #103] (Resolved) Ride Editor with tools
golden.ch...@gmail.com
----------------------------------------
Feature #103: Ride Editor with tools
http://bugs.goldencheetah.org/issues/show/103
Author: Mark Liversedge
Status: Resolved
Priority: Normal
Assigned to: Mark Liversedge
Category:
Target version:
A feature to edit raw data in a spreadsheet-like view with support for search, copy/paste, undo etc. There are associated tools for manipulating samples such as fixing gaps in recording, fixing bad GPS data, adjusting torque values when PM calibration was out and fixing spikes in power under the Tools menu option.
The patch below is pretty well tested through lots of iterations in the design and refactoring of the code (three times!!). But since it is pretty radical you should backup your data before using it.
I will write up a guide, some developer notes and get a tutorial video together over the next few days, but for now give it a whirl!
I have tested on Linux/Mac but not so much on Windows - esp. the clipboard stuff (copy/paste) - all feedback welcome!
I would like to extend the undo/redo feature to the metadata fields too, but will send through as a separate patch.
Here is the commit message:
Ride editor and tools
A new tab 'Editor' for manually editing ride file data points and
associated menu options under 'Tools' for fixing spikes, gaps, GPS
errors and adjusting torque values. A revert to saved ride option
is also included to 'undo' all changes.
The ride editor supports undo/redo as well as cut and paste and
"paste special" (to append points or swap columns/overwrite
selected data series). The editor also supports search and will
automatically highlight anomalous data.
When a file is saved, the changes are recorded in a new metadata
special field called "Change History" which can be added as a
Textbox in the metadata config.
The data processors can be run manually or automatically when a
ride is opened - these are configured on the ride data tab in
the config pane.
Significant changes have been introduced in the codebase, the most
significant of which are; a RideFileCommand class for modifying
ride data has been introduced (as a member of RideFile) and the
RideItem class is now a QObject as well as QTreeWidgetItem to
enable signalling. The Ride Editor uses a RideFileTableModel that
can be re-used in other parts of the code. LTMoutliers class has been
introduced in support of anomaly detection in the editor (which
highlights anomalies with a wiggly red line).
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.goldencheetah.org/my/account
Gareth
the GoldenCheetah executable and you can drop it in next to any of the
development builds that I have done in the past and run the new
executable for testing.
As Mark says, backup data. I also recommend making a new user for
testing under.
More details at: http://goldencheetah.stand2surf.net/?p=154
Mark Liversedge
I might have to download it and try it myself :-)
SteveI
> If you are on Windows and want to test this out I have created just
> the GoldenCheetah executable and you can drop it in next to any of the
> development builds that I have done in the past and run the new
> executable for testing.
Mark, do the little green triangles in some cells signify data that
has been auto-corrected?
I'm just asking because I have some spikes I'm trying to get rid of,
and the critical power tab tells me which ride I need to look in, but
when I look in the editor, there are no spikes, but there are some non-
integer values, so was wondering if they have been auto-detected and
interpolated?
Another early observation is that the little red squiggly underlining
isnt easy to spot if you scroll down the data. Buttons at the top to
jump to next/prev red squiggle might be handy.
Mark Liversedge
precision than we expect and precision will be lost if you edit it.
E.g. Heartrate BPM values which are not integers. This is typically
caused by the TCX file reader interpolating points e.g. 10bpm to 11bpm
over 4 secs results in 10, 10.25, 10.5, 10.75, 11.
I set the editor to a "sensible" value for editing numbers, e.g.
power, cadence, hr are integers, whilst lat/lon have 6 decimal places.
The find anomaly thing is a fair point, will add << and >> arrows for
prev/next anomaly.
SteveI
earlier message.
I think the problem I'm having is nothing to do with your work, it has
just highlighted an existing problem now that I'm trying to fix it
with your editor.
I go to my critical power page, and can see it going up to >4000W at
the far left. I click on it at the 1 second point and it says best
2431W 6/6/10.
Now, the first problem is that the best value doesn't match what is
showing on the graph, because the graph clearly shows it above 4000W,
when it says the best is 2431W.
Second problem is when I go to the file from that date, the dark line
for the ride critical power coincides with the top of the graph, i.e.
it's the right file, BUT in the ride summary data it says max power is
only 513W. The critical power tab, OTOH, says today 2431W. The editor
matches the ride summary, with just the one value above 500W, the
stated max of 513W.
I tried deleting all the cached data and letting it calculate
everything again from scratch, but same outcome.
Mark Liversedge
> Thanks, Mark. Great work, btw, very rude of me to not say that in my
> earlier message.
> I think the problem I'm having is nothing to do with your work, it has
> just highlighted an existing problem now that I'm trying to fix it
> with your editor.
>
> I go to my critical power page, and can see it going up to >4000W at
> the far left. I click on it at the 1 second point and it says best
> 2431W 6/6/10.
>
> Now, the first problem is that the best value doesn't match what is
> showing on the graph, because the graph clearly shows it above 4000W,
> when it says the best is 2431W.
duration less than a second ?
> Second problem is when I go to the file from that date, the dark line
> for the ride critical power coincides with the top of the graph, i.e.
> it's the right file, BUT in the ride summary data it says max power is
> only 513W. The critical power tab, OTOH, says today 2431W. The editor
> matches the ride summary, with just the one value above 500W, the
> stated max of 513W.
it?
H Heyermans
Was just using the ride editor and when I highlighted the power column
and then did a right click the program crashed. It did this every time
after re-opening the program and doing the same steps. I'm using
windows XP Pro. I also have a laptop with vista, I'll try it there
later.
Harold
On Jun 28, 3:28 pm, golden.cheetah.b...@gmail.com wrote:
> Issue #103 has been reported by Mark Liversedge.
>
> ----------------------------------------
SteveI
> Was just using the ride editor and when I highlighted the power column
> and then did a right click the program crashed. It did this every time
> after re-opening the program and doing the same steps. I'm using
> windows XP Pro. I also have a laptop with vista, I'll try it there
> later.
have just managed to reproduce it, the crucial detail being that you
have to right click on the column heading, not anywhere else on the
column. It isn't necessary to select the column first, and it isn't
just the power column, just right click on any column heading and it
crashes.
Not a problem in practice as I'm not sure why you'd need to right
click on a column heading?
Mark Liversedge
Gareth's build and then compiled up my own and its fine. I have a
sneaking suspicion that the binary Gareth made available is not in
sync with the previously installed libraries. Best way to check would
be to get an installer built and try that?