Compare whole activities

[marcen]

Hello,

With the GC version from 10.07 I noticed that whole activities can no longer be compared.

Intervals work.

[Ale Martinez]

I cannot track this to a specific change, it looks like a regression.

It would be interesting to find out from which build it started to happen, and if it also happens no macOS/Linux or it is Windows specific. 

[Joss Winn]

In the latest (July 11th) macOS snapshot, I can compare the ‘Entire Activity’ of two or more activities. 

[Ale Martinez]

I think the OP refers to drag an activity from the activity list, 'Entire Activity' is just an interval, and to drag it is the workaround for this issue.

I tested Linux AppImage on Windows 11 WSL (it works after apt-get a couple of missing libraries) and activities from the activity list cannot be dropped to the compare pane, this also happens with RC1, so it looks like this has been present for a while. 

[Joss Winn]

I’ve just tried dragging the whole activity from the Activities list and it works fine, too. 

[Ale Martinez]

Thank you, main difference is macOS build still uses Qt5.14, Windows and Linux are on Qt5.15 now, a previous Linux build using Q5.14 does not exhibit this behavior either. 

[marcen]

Exactly, if activities from the activity list drop into the compare pane, it does not work.

Unfortunately, I have already deleted my old GC version to see if there was already the problem.

For me GC runs under Archlinux.

I have not tested GC under Windows

[Mark Liversedge]

$ git log --oneliner --follow src/Gui/ComparePane.cpp

c85054ed6 ComparePane - Filter segments matching sport
cb092b9d7 Interval Metric config becomes Favourite Metrics
9a0b6e0bc qSort is deprecated, use std::sort
e79b474ea Add Context Help to Compare Pane and Workout Control
aaa788917 make the date range of relative seasons (e.g. in Trends) update as time passes (#3546)
fbd095a2d Split Global and Athlete configuration
80d7eed38 RideMetadata and friends moved to GlobalContext
1d9f570ed Introduce a Global Context
f51a6a6cb Remove Conditional Compilation for Qt < 5.9 (#3464)
c28966a1b Fix Compare Rides across Athletes Bug

I fancy c85054ed6 or c28966a1b is the culprit?

Mark

[Ale Martinez]

El martes, 12 de julio de 2022 a la(s) 17:58:58 UTC-3, liver...@gmail.com escribió:

$ git log --oneliner --follow src/Gui/ComparePane.cpp

c85054ed6 ComparePane - Filter segments matching sport
cb092b9d7 Interval Metric config becomes Favourite Metrics
9a0b6e0bc qSort is deprecated, use std::sort
e79b474ea Add Context Help to Compare Pane and Workout Control
aaa788917 make the date range of relative seasons (e.g. in Trends) update as time passes (#3546)
fbd095a2d Split Global and Athlete configuration
80d7eed38 RideMetadata and friends moved to GlobalContext
1d9f570ed Introduce a Global Context
f51a6a6cb Remove Conditional Compilation for Qt < 5.9 (#3464)
c28966a1b Fix Compare Rides across Athletes Bug

I fancy c85054ed6 or c28966a1b is the culprit?

I tried reverting both and the problem persists, interestingly building with Qt5.14.2 on Windows neither fixes it, I ran out of ideas. 

[Mark Liversedge]

I will look at the weekend, is this a drag event from the sidebar?

Mark

[Ale Martinez]

Yes, when dragging an activity from the sidebar drop over the compare pane is forbidden. Intervals drag&drop works as intended. 

[Mark Liversedge]

Its a QT bug- there are a number of drag and drop regressions from 5.12.x since 5.11 worked fine.

I looked to work around it, but the simple answer is to build with Qt > 5.15.1 where most of these regressions finally got fixed.

Mark

[Ale Martinez]

El domingo, 17 de julio de 2022 a la(s) 10:23:20 UTC-3, liver...@gmail.com escribió:

Its a QT bug- there are a number of drag and drop regressions from 5.12.x since 5.11 worked fine.

I looked to work around it, but the simple answer is to build with Qt > 5.15.1 where most of these regressions finally got fixed.

Both Windows and Linux snapshot builds are on Qt5.15.2

I updated the open issue covering the 2 compare pane problems with their workarounds: https://github.com/GoldenCheetah/GoldenCheetah/issues/3622#issuecomment-1189021079