"reveal" area too large?

[Claus Assmann]

Using the latest code I noticed that the "reveal" menue shows up
in the "Ride" display when I move the cursor near to the top of a
line to see its value. For example, the BPM Y-axis ends at 180,
and the cursor is moved to a value of about 172: at that moment the
hidden menue shows up, the ride graphics is moved down and hence
the cursor isn't anymore on the line which I tried to follow.

I hacked HomeWindow.cpp which seems to "fix" the problem, but I
have no idea whether this is correct. IMHO the menu shouldn't show
up as long as the cursor is "inside" the graph.

BTW: I don't really like those kind of "jumping" UIs, but that's
probably a matter of taste... what was wrong with the menu window
that can be opened and moved to a non-intrusive location by the
user?


diff --git a/src/HomeWindow.cpp b/src/HomeWindow.cpp
index 92e609d..ac0bacc 100644
--- a/src/HomeWindow.cpp
+++ b/src/HomeWindow.cpp
@@ -858,13 +858,13 @@ HomeWindow::eventFilter(QObject *object, QEvent *e)
if (us->underMouse()) { // is it even under the cursor?

// mouse towards top so reveal
- if (us->revealed == false && pos.y() < 90) {
+ if (us->revealed == false && pos.y() < 50) {
us->reveal();
us->revealed = true;
}

// hide as mouse moves away
- if (us->revealed == true && pos.y() > 90) {
+ if (us->revealed == true && pos.y() > 50) {
us->unreveal();
us->revealed = false;
}

[Mark Liversedge]

On Monday, 14 January 2013 22:25:11 UTC, Claus Assmann wrote:

BTW: I don't really like those kind of "jumping" UIs, but that's 
probably a matter of taste... what was wrong with the menu window
that can be opened and moved to a non-intrusive location by the
user?

Lots of users want controls on the charts, because a) thats how it used to work and b) they  like it that way.

From a usability perspective it is overwhelming for new users and it takes up screen estate  which can confuse or grate with some, like you say depending upon taste.

Its a balance between what "advanced" users want and making a UI that isn't shit. 

[Mark Liversedge]

On Monday, 14 January 2013 22:25:11 UTC, Claus Assmann wrote:

I hacked HomeWindow.cpp which seems to "fix" the problem, but I 
have no idea whether this is correct. IMHO the menu shouldn't show
up as long as the cursor is "inside" the graph.

Its not correct. The font metrics and spacing on a Mac mean you have made it impossible to click on the controls in the histgram window!! Are you working on a PC with a small font size (8pt?).

The menu is still there, with all the chart controls. We just started to put a selection on the top of the chart. It is intended to mimic the controls in Mac mail (in concept at least). The jumping thing can be addressed later.

[Claus Assmann]

On Mon, Jan 14, 2013, Mark Liversedge wrote:

> Its not correct. The font metrics and spacing on a Mac mean you have made
> it impossible to click on the controls in the histgram window!! Are you
> working on a PC with a small font size (8pt?).

It's a laptop with screen resolution of 1680x1050 (running X). As
I mentioned: my intention was that the menue stays hidden while the
cursor is below the end of the Y-axis.

This seems to work a bit better if two different values are used:
< 50 and > 90 works for my layout.

[Mark Liversedge]

Done. Just pushed. FWIW, the diff you posted changed both to 50 :

[Claus Assmann]

On Mon, Jan 14, 2013, Mark Liversedge wrote:

> Done. Just pushed. FWIW, the diff you posted changed both to 50 :

Yes, that was my first (incorrect) attempt. After your comment about
not being able to actually use the menue (on the Mac) I changed it,
but didn't include the modified patch.

Thanks!