Improving CORE support?

[Jonathan Savage]

GC has support for displaying core temperature from the CORE sensor. However, I find that of far less value than the Heat Strain Index. 

I forked GC and added support for displaying HSI and skin temperature, both as numeric displays and graph lines. 

Is this something I should look to contribute to the main code base? (I've never contributed to GC or any other public github, though I was a software engineer for decades.) 

Jonathan 

[Ale Martinez]

Hi Jonathan, welcome to the project, there is a document in the wiki which may help: https://github.com/GoldenCheetah/GoldenCheetah/wiki/Guidelines-for-submitting-a-patch 

Cheers, Ale.

[Jonathan Savage]

I've uploaded a patch file to the issue I created. Let me know what else I need to do, or if I took the wrong approach. 

https://github.com/GoldenCheetah/GoldenCheetah/issues/4665

Thanks, Jonathan 

[Ale Martinez]

El viernes, 11 de julio de 2025 a la(s) 10:34:00 a.m. UTC-3, Jonathan Savage escribió:

I've uploaded a patch file to the issue I created. Let me know what else I need to do, or if I took the wrong approach. 

Hi Jonathan for small modifications patch files are Ok, otherwise GitHub pull request are much better since you have automatic ci builds and they are easier for maintainers to review, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

Thanks, Ale. 

[Jonathan Savage]

I'm not sure how to proceed. I don't have write permission to create a branch in the main GC repo, but I already have a fork of GC that has my personal changes that I don't intend to feed back. It looks like I'd have to create a second account, use that to fork GC, apply the patch of my changes to the second fork, then create a pull request from there. 

Am I missing something? 

Jonathan 

[Poncho]

You can create a branch in your fork. That branch needs to be in line
with the upstream master branch.
Then you can add the commits that you want to contribute
(cherry-picking) to that branch and open a pull request.

You don't need a second account or a second fork.

It's git. It's a bit hard to explain. If you get the hang of it, it will
make sense eventually 🤷‍♂️

[Jonathan Savage]

Thanks! It was a bit confusing, especially being able to create a branch in a fork that's based on a later branch of the main fork. But I think it worked, and it looks like there's a new pull request in the main GC fork. 

Let me know if this looks okay, or if I got something wrong. 

Jonathan 

[Ale Martinez]

Yes, it looks ok, thank you!