Pull requests

[Paul J]

While I was furloughed I created a number of pull requests for various features, and I'm wondering whether and when they are going to merged back into the build?

My concern is that there are pull requests dating back to October 2017 which haven't been merged, and I'd rather not have my efforts become nugatory effort, as the longer changes sit outside the main build the more difficult they become to merge. Therefore to assist in the merge process, I'm happy to support a Zoom call or similar to discuss and walk through these changes if the information in the pull requests is insufficient, the changes are:

• Expand new activity lines on auto import & dynamic resizing of Calendar text within Ride Navigator #3820
• Power Spike Filtering #3814
• Auto import filtering, file import exclusion and file overwrite option #3770
• Fixed command line parameter handling #3767
• Map chart route line changes and removal of unused styleOptions functions #3799

I wish to continue contributing to the project, so maybe you can provide some schedule/target date of when these changes will be considered?

Regards,

Paul.

[Ale Martinez]

El domingo, 7 de marzo de 2021 a la(s) 05:31:11 UTC-3, paulj...@gmail.com escribió:

While I was furloughed I created a number of pull requests for various features, and I'm wondering whether and when they are going to merged back into the build?

We have a backlog of pending issues, new features and pull requests, regrettably the maintainers time is a limited resource and we cannot give you a schedule, for the same reasons we don't provide one to users as explained in https://groups.google.com/g/golden-cheetah-users/c/Wuw1XpTamRA/m/6gePTMneAQAJ

We have some guidelines to make the review process safer and faster, PR's adhering to them are more likely to be reviewed and merged provided they fix a relevant issue or propose a generally useful feature, changes intended to customize workflows for personal preference or refactor-only changes are less likely to be merged, IME.