Saving of Interval data

[Paul J]

I'm working on the metadata tile to display interval metadata, and see the following code/comment at the bottom of the FormField::editFinished() function (see below)

Is it the intention not to store the user entered interval data by default? I have tested this, and interval data can be entered (and will be saved) providing another data item is updated so that the ride is marked as dirty. Otherwise the user enters interval data, is not reminded to save the ride, and the input is lost.


void FormField::editFinished()

{

..........

..........

    // update everything, because metric changes like CP
    // need to flush through. For interval metadata we
    // don't force a recalculation since its counter-productive
    // user can save the activity if they really want the changes
    // to be reflected now
    if (changed && definition.interval == false) {

        // we actually edited it !
        setLinkedDefault(text);

        // and update !
        ourRideItem->notifyRideMetadataChanged();

        // rideFile is now dirty!
        ourRideItem->setDirty(true);
    }
    meta->active = active = false;
}

[Ale Martinez]

El miércoles, 2 de julio de 2025 a la(s) 4:30:39 a.m. UTC-3, Paul J escribió:

I'm working on the metadata tile to display interval metadata, and see the following code/comment at the bottom of the FormField::editFinished() function (see below)

Is it the intention not to store the user entered interval data by default?

The comment seems to indicate otherwise but I don't know Mark's intentions, all we have about this feature is in https://github.com/GoldenCheetah/GoldenCheetah/issues/4418

[Paul J]

I'll wait for Mark's views before continuing with the Metadata tile displaying the selected interval.