Typo in Macro?

9 views

Skip to first unread message

Joachim Kohlhammer

unread,

Mar 15, 2025, 8:16:50 AM3/15/25

to golden-cheetah-developers

While looking through the invisible button-labels caused by Qt 6.8.2, I stumbled over the use of a macro Q_OS_MAX:

$ rg Q_OS_MAX src
src/Gui/SplitActivityWizard.cpp
35:#ifdef Q_OS_MAX

src/Charts/UserChart.cpp
852:#ifdef Q_OS_MAX
888:#ifdef Q_OS_MAX

src/Charts/ReferenceLineDialog.cpp
61:#ifdef Q_OS_MAX

src/Charts/AllPlotWindow.cpp
127:#ifdef Q_OS_MAX

src/Charts/LTMTool.cpp
255:#ifdef Q_OS_MAX

src/Charts/ExhaustionDialog.cpp
59:#ifdef Q_OS_MAX

src/Gui/PerspectiveDialog.cpp
46:#ifdef Q_OS_MAX
63:#ifdef Q_OS_MAX

src/FileIO/XDataDialog.cpp
47:#ifdef Q_OS_MAX
61:#ifdef Q_OS_MAX

As I couldn't find any reference to this in the Qt-docs, I assume it should be Q_OS_MAC instead. Are my thoughts correct, should I create a PR?

Ale Martinez

unread,

Mar 15, 2025, 9:12:34 AM3/15/25

to golden-cheetah-developers

Agree it looks like a typo, likely propagated by copy paste, but considering it goes back to more than 10 years I am not sure we should enable that code replacing by Q_OS_MAC or just remove those inactive blocks of code.