url.Parse() Host & Port

[Ryan Macy]

Why doesn't url.Parse() break host and port apart? Is that intended?

http://play.golang.org/p/p0h4t9Q7Nq

[Dave Cheney]

If it did break apart the Host and the Port, where would it put the Port ?

http://golang.org/pkg/net/url/#URL

On Sat, Jan 19, 2013 at 7:16 AM, Ryan Macy <ry...@hackery.io> wrote:
> Why doesn't url.Parse() break host and port apart? Is that intended?
>
> http://play.golang.org/p/p0h4t9Q7Nq
>

> --
>
>

[Ryan Macy]

Well, we would have to add a field called "Port" and put it in there.

Is that something we would want to do?

[Dan Kortschak]

Even apart from the Go1 guarantee, what does that get you? If the Port field is an int you need to convert from a string to fill the field and then back to a string plus concatenation to use the Url. If it's a string you don't get much extra benefit over strings.Split(u.Host, ":").

--
 
 

[Andy Balholm]

On Friday, January 18, 2013 3:00:18 PM UTC-8, kortschak wrote:

Even apart from the Go1 guarantee, what does that get you? If the Port field is an int you need to convert from a string to fill the field and then back to a string plus concatenation to use the Url. If it's a string you don't get much extra benefit over strings.Split(u.Host, ":").

But you should use net.SplitHostPort rather than strings.Split when you do need to split them, since it handles IPv6 addresses correctly. 

[Mikio Hara]

On Sat, Jan 19, 2013 at 8:30 AM, Andy Balholm <andyb...@gmail.com> wrote:

> But you should use net.SplitHostPort rather than strings.Split when you do
> need to split them, since it handles IPv6 addresses correctly.

I'm afraid that a literal IPv6 address and a literal IPv6 address in
URI are different.
E.g.,
- [fe80::1%en0] // http://tools.ietf.org/html/rfc4007
- https://[fe80::1%25en0] //
http://tools.ietf.org/html/draft-ietf-6man-uri-zoneid-06

[Dan Kortschak]

Yes. Still thinking in IPv4.

[Dave Cheney]

Also remember that not all URLs are hrefs, eg what would the Port member mean when parsing a mailto: ?

[Dan Kortschak]

Yes. Another argument for not including a Port field.

[Dave Cheney]

Also, what should the port be set to for

http://example.com/

?

[Ryan Macy]

I see the reasoning for the exclusion of "Port", net.SplitHostPort solves this need.

Also, what should the port be set to for

http://example.com/

...snip...

Also remember that not all URLs are hrefs, eg what would the Port member mean when parsing a mailto: ?

If the port isn't there to parse, can it not just be 0?

Thanks for the responses!

_Ryan

[DisposaBoy]

I'm not in a position to search for a link that explains . but Yeh simple answer is no. port zero has significant meaning depending on the context. e.g. when listening on a socket it yells some? OS to pick an available port