net/smtp Quit should prolly have a better return value

[Christian Schmitt]

Hello currently I struggled to keep my webserver up after sending a mail,

that was caused since I had something like that in my code:

if err = c.Quit(); err != nil {

log.Fatal(err)

}

I kept searching and if read the Docs so carefully.. (https://golang.org/pkg/net/smtp/#Client.Quit)

However Quit() doesn't return just an error as it seems...

We should prolly fix that to standard go like (string, error). Since the 250 Ok Message of the Client will also be an error, which is of course not an error and it will shut your program down, if you check for an error..

https://github.com/golang/go/blob/master/src/net/smtp/smtp.go#L373-L383

[Andrew Gerrand]

Hi Christian,

Why would the 250 OK message from the client be an error?

I'm reading the code, and I don't see anything but actual errors being returned by Quit.

What am I missing?

Andrew

--
You received this message because you are subscribed to the Google Groups "golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Christian Schmitt]

I used it with AWS SES and It returned the following:

    14:17:30 app         | 2015/06/30 14:17:30 Quit Message: 250 Ok 0000014e44669548-f3afa74a-3a31-41ea-b2c6-f7a61b9f63e9-000000

Currently this is my code:

https://gist.github.com/schmitch/1571d2c15864202830ab

I'm not sure but 250 Ok doesn't seems to be an error...

[Bruno Albuquerque]

Quit seems to expect code 221 and, if I understand the code, everything else is considered an error. So 250 is an error.

This looks like a bug.

[Christian Schmitt]

Looks like that happens when you don't call w.Close.. 

Sorry looks like my fault.

[Bruno Albuquerque]

FYI.

Looking at the RFC (https://tools.ietf.org/html/rfc821), it looks like the SMTP server being used is at fault. It should not reply with code 250 when it gets a QUIT command. It should be 221.