go.crypto/ssh/server.go - Ability to change the outgoing server version

[Blake Caldwell]

Are there any reasons not to support allowing an outgoing SSH server's version string to be customized? This currently is reported as SSH-2.0-Go. I'd rather not advertise what server tech I'm using, and I'm sure others feel the same.

I have a patch to go.crypto/ssh/server.go that allows the caller to change this, falling back to the current value as default.  I'd like to submit it, but wanted to check here first.

[Jonathan Pittman]

This does not answer your initial question, but how is advertising "SSH-2.0-Go" any worse than what OpenSSH does (SSH-2.0-OpenSSH_6.2)?

[Blake Caldwell]

SSH-2.0-Go is _much_ better than SSH-2.0-OpenSSH_6.2. The latter gives me heartburn.

In my case, I'd like to include information about my application in the banner. We're using Paramiko on Python right now, returning our service version. I'd like to migrate this service to Go, and not fork the ssh package. I figure I can't be the only one that'd like this flexibility, so I'd like to submit a patch.

[Jonathan Pittman]

I would suggest filing an issue on the tracker and then sending your patch for review.  Worst case, they say no (hopefully providing a reason why).  Best case, you get your feature.

--
You received this message because you are subscribed to a topic in the Google Groups "golang-nuts" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/golang-nuts/ZygRm-dz2BA/unsubscribe.
To unsubscribe from this group and all its topics, send an email to golang-nuts...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Han-Wen Nienhuys]

On Thursday, July 31, 2014 9:35:32 PM UTC+2, Jonathan Pittman wrote:

I would suggest filing an issue on the tracker and then sending your patch for review.  Worst case, they say no (hopefully providing a reason why).  Best case, you get your feature.

 

On Tue, Jul 29, 2014 at 11:58 AM, Blake Caldwell <blakec...@gmail.com> wrote:

SSH-2.0-Go is _much_ better than SSH-2.0-OpenSSH_6.2. The latter gives me heartburn.

In my case, I'd like to include information about my application in the banner. We're using Paramiko on Python right now, returning our service version. I'd like to migrate this service to Go, and not fork the ssh package. I figure I can't be the only one that'd like this flexibility, so I'd like to submit a patch.

On Wednesday, July 23, 2014 6:18:41 PM UTC-4, Jonathan Pittman wrote:

This does not answer your initial question, but how is advertising "SSH-2.0-Go" any worse than what OpenSSH does (SSH-2.0-OpenSSH_6.2)?

On Wednesday, July 23, 2014 10:27:39 AM UTC-4, Blake Caldwell wrote:

Are there any reasons not to support allowing an outgoing SSH server's version string to be customized? This currently is reported as SSH-2.0-Go. I'd rather not advertise what server tech I'm using, and I'm sure others feel the same.

I have a patch to go.crypto/ssh/server.go that allows the caller to change this, falling back to the current value as default.  I'd like to submit it, but wanted to check here first.

I don't think there is much problem with being able to set the server version. There is one caveat, which is that the other end might use workarounds for known bugs, so you'd better not send a version string of something else, say OpenSSH.