Code Review Checklist: Go Concurrency

340 views
Skip to first unread message

Roman Leventov

unread,
Mar 21, 2021, 4:23:00 PM3/21/21
to golang-nuts
I've created a list of possible concurrency-related bugs and gotchas in Go code: https://github.com/code-review-checklists/go-concurrency.

The idea of this list is to accompany https://github.com/golang/go/wiki/CodeReviewComments and https://golang.org/doc/articles/race_detector#Typical_Data_Races (my list actually refers to a couple of data races described in the list of "Typical Data Races").

Comments, corrections, additions are welcome!

If there are some core Go developers reading this, I would also like to know if you think some of the points from my list can be moved to https://github.com/golang/go/wiki/CodeReviewComments.

Ian Lance Taylor

unread,
Mar 23, 2021, 6:29:26 PM3/23/21
to Roman Leventov, golang-nuts
Thanks. This seems useful. It's not quite the kind of thing that we
have on the CodeReviewComments page, which is more about style than
correctness. I think it would be fine as another wiki page, or where
you already have it.

Ian

John Dreystadt

unread,
Mar 31, 2021, 1:36:29 PM3/31/21
to Ian Lance Taylor, Roman Leventov, golang-nuts
As still quite the newbie at Go, I agree about the usefulness. Several years ago I ran into a paper on this subject at a blog called the Morning Paper (sadly gone quiet). The paper itself is at https://songlh.github.io/paper/go-study.pdf . It has some examples and might be a useful addition to the list of reading materials. 

JohnD

--
You received this message because you are subscribed to the Google Groups "golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CAOyqgcWBJEYNFo-o5VpaoSFMcx9kfivENcR9Di-dh1-ZhdLg6w%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages