strings.IndexAll?

[Ilya Kowalewski]

Hey there,

// IndexAll returns indeces of all instances of sep in s.
func IndexAll(s, sep string) []int

The function signature above looks like one I'd love to see in strings package. We've got Index and IndexLast already though. Would my implementation get rejected if I submit one?

[Brad Fitzpatrick]

The standard library is mostly frozen. This probably wouldn't meet the utility bar.

--
You received this message because you are subscribed to the Google Groups "golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[David Symonds]

It doesn't seem like a particularly significant addition. Any use of
it would probably be better written as an explicit loop, calling Index
repeatedly, which would not require memory allocation (like your
suggestion would).

for i := strings.Index(s, sep); i >= 0; i += strings.Index(s[i:], sep) {
... // i is the next index
}

[David Symonds]

(oh, except you'll need an extra +1 in my code. that'll teach me.)

[Dan Kortschak]

Would this work for you? Otherwise David's is simple.

https://golang.org/pkg/index/suffixarray/

[Ian Byrd]

Your implementation results in an endless loop, this is the correct one:

for i := strings.Index(s, sep); i >= 0; {

// utilizing s[i:]

// the next instance

j := strings.Index(s[i+1:], sep)

if j >= 0 {

i += j + 1

} else {

break

[Ian Byrd]

Wow, didn't know stdlib had builtin suffix trees! Pretty handy, thanks.

[Tim K]

It's Google we're talking about here. Search is their bread & butter :-)