Code style in golang compiler

[messi...@gmail.com]

Hi,

I'm reading the go compiler source code and found the following code style in several places:

Is there some special reasons to group n,m,p to a local struct? 

Why don't we just init n the following way:

[Dan Kortschak]

On Mon, 2021-02-08 at 19:09 -0800, messi...@gmail.com wrote:
> Hi,
>
> I'm reading the go compiler source code and found the following code
> style in several places:
>
>
>

> Is there some special reasons to group n,m,p to a local struct?
>
> Why don't we just init n the following way:

Maybe because the Node, Name and Param will all be allocated in a
single contiguous allocation in the form that exists in the current
tree.



BTW Please don't post images for source code.

[Luke Champine]

git blame is instructive here. The commit in question is: https://github.com/golang/go/commit/166b1219b8a5b246c83986c7ecef3d15c85c8150

I can't claim to fully understand the commit message, but I believe that this change will cause the runtime to allocate both values together, rather than separately, and this slightly reduces GC pressure.

[messi...@gmail.com]

Thanks, the commit message explains everything :-)