Automated Gerrit reviews

99 views
Skip to first unread message

henri....@gmail.com

unread,
Jul 12, 2019, 8:55:12 AM7/12/19
to golang-nuts
I wrote small tool which takes various linter reports as input and posts those as comments to gerrit reviews. I use it at work with golangci-lint in our Jenkins CI pipe.
Any feedback is much appreciated. =)

Ivan Borshukov

unread,
Jul 12, 2019, 10:18:34 AM7/12/19
to henri....@gmail.com, golang-nuts
Thanks for sharing, it looks quite interesting. 

Do you think it would be possible (and easy) to extend the tool to support posting comments in GitLab or GitHub?

There are times that some static check failures are ok, but that’s now always the case. So instead of failing the build or tests it would be great to have a bot commenting on the change itself, leaving an option for the submitter to resolve the discussion (possibly with explanation why). 

Thanks,
Ivan

--
You received this message because you are subscribed to the Google Groups "golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/2a66f4e0-284a-499e-8388-0e7ced6fe772%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Ivan Borshukov, bo0m...@gmail.com

Brian Hatfield

unread,
Jul 12, 2019, 10:21:52 AM7/12/19
to Ivan Borshukov, henri....@gmail.com, golang-nuts
For Github, integration with the Checks API seems like the way you'd do it: https://developer.github.com/v3/checks/

Henri Koski

unread,
Jul 13, 2019, 12:23:52 AM7/13/19
to Brian Hatfield, Ivan Borshukov, golang-nuts
Looks like adding github checks support wouldn't be too hard to implement. I can try to do it once I'm back from holiday.
Reply all
Reply to author
Forward
0 new messages