Why key.PublicKey.Equal(key.PublicKey) return false ?

[christoph...@gmail.com]

I have the following test that fails reporting a key  mismatch.

func TestKeyEqual(t *testing.T) {

     key, err := rsa.GenerateKey(rand.Reader, 2048)

     if err != nil {

         t.Fatal("failed generating private key: ", err)

     }

     if !key.PublicKey.Equal(key.PublicKey) {

         t.Fatal("key mismatch")

     }

}

Why is that ? Shouldn’t it return true ?

Initially I compared key after save and reload read, and since it failed, I just tested the same key for equality to verify that Equal was working as expected. Apparently it does not or I’m doing something wrong.

[christoph...@gmail.com]

My formulation was not clear. The test fails, and it reports a key mismatch.

[Jason Phillips]

The implementation of Equal() expects the PublicKey argument to be a pointer to an rsa.PublicKey. If you do the following it works:

if !key.PublicKey.Equal(&key.PublicKey) {

    t.Fatal("key mismatch")

}

It should probably be documented as such.