moving code reviews off golang-dev

501 views
Skip to first unread message

Russ Cox

unread,
Dec 19, 2013, 9:22:28 PM12/19/13
to golang-dev
We’ve been talking for a few months about moving automated mail off golang-dev, so that golang-dev only has real discussions and is a bit easier to follow. In particular we want to move code reviews off the list: not everyone cares about every directory or every change, and there is enough going on that any real discussion gets lost in the noise.

We now have the tools in place to make this happen. As of tomorrow, the golang-dev@ list will no longer receive code review mails. If you're interested in participating in coding and code review for the Go project, please read the rest of this message carefully. Changes are coming soon.

First, we have created a new mailing list golang-co...@googlegroups.com that will be CC’ed on every code review. If you want to see them all, that’s the list to subscribe to. Another useful way to set things up is to subscribe to the list but create a mail filter that hides the message if it’s not to you; for example in Gmail you might set the filter [to:golang-codereviews -to:me] to bypass the inbox. Then if you are added mid-way through a CL, you’ll still have all the history in the thread.

Second, we have also created a dashboard go-dev.appspot.com that summarizes pending code reviews and open Go 1.3 issues. If you are wondering what requires your attention or what is going on, the dashboard is the suggested way to find out without reading all the mail to golang-codereviews. The dashboard will be refined over time, but we believe it is already useful enough to move the code reviews off golang-dev, and doing so will force us to use the dashboard and fix the rough edges.

Finally, we will change the default CC in the main repo and all subrepos tomorrow, and we will also change all pending CLs to replace golang-dev with golang-codereviews.

See the doc at golang.org/s/go-dev-howto for information about how to use the dashboard. Comments and questions are welcome in this thread.

Russ, for the Go team

P.S. Many of us will be away for the next two weeks due to the holidays, so code reviews will be a bit slow until people are back in January. We hope that it will be easier to catch up this time, since golang-dev will have just discussions and the dashboard will summarize what code reviews and issues need attention.

Dave Cheney

unread,
Dec 19, 2013, 9:39:29 PM12/19/13
to Russ Cox, golang-dev
The new dashboard looks great.

Will gocodereview.appspot.com be rolled into/done away with also?


--
 
---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Russ Cox

unread,
Dec 20, 2013, 11:52:07 AM12/20/13
to golang-dev
On Thu, Dec 19, 2013 at 9:22 PM, Russ Cox <r...@golang.org> wrote:
Finally, we will change the default CC in the main repo and all subrepos tomorrow, and we will also change all pending CLs to replace golang-dev with golang-codereviews.

This is done. There are probably some repos we missed (I know we missed some side projects like snappy-go); please update the codereview.cfg in those repos if you work in them.

People who have not run 'hg sync' to get the new configs or who work in repos not yet converted will still be sending CLs to golang-dev, but gobot will move them to golang-codereviews with instructions to run hg sync or update the repo, like on codereview.appspot.com/44610043.

Russ

tracey....@gmail.com

unread,
Dec 21, 2013, 1:38:03 AM12/21/13
to golan...@googlegroups.com
Is there going to be an effort made to have extended code review discussions (that are about design) to golang-dev (via cc-ing or some other process)? For example, the recent discussion on adding the Pool type was somewhere in between a code review and a design discussion. I'm not sure how frequent that sort of thing is, but just wondering if I should keep my eye on the new site for discussions like that, or if I can assume any such discussion would be moved here.

Thanks!

brainman

unread,
Dec 21, 2013, 4:21:19 PM12/21/13
to golan...@googlegroups.com
Do we need to change http://golang.org/doc/contribute.html?

Alex

Reply all
Reply to author
Forward
0 new messages