Re: code review 7473044: cmd/gc: support channel types in the garbage collector (issue 7473044)

[dvy...@google.com]

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c
File src/pkg/runtime/mgc0.c (right):

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c#newcode716
src/pkg/runtime/mgc0.c:716: chan_ret = 0;
s/0/nil/

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c#newcode975
src/pkg/runtime/mgc0.c:975: runtime·lock(&lock);
why do you need this lock?

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c#newcode1008
src/pkg/runtime/mgc0.c:1008: if(chan_ret == 0) {
s/0/nil/
drop {}

https://codereview.appspot.com/7473044/

[0xE2.0x...@gmail.com]

Hello golan...@googlegroups.com, dvy...@google.com (cc:
golan...@googlegroups.com, r...@golang.org),

Please take another look.


https://codereview.appspot.com/7473044/

[0xE2.0x...@gmail.com]

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c
File src/pkg/runtime/mgc0.c (right):

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c#newcode716
src/pkg/runtime/mgc0.c:716: chan_ret = 0;

On 2013/03/08 15:16:35, dvyukov wrote:
> s/0/nil/

Done.

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c#newcode975
src/pkg/runtime/mgc0.c:975: runtime·lock(&lock);

On 2013/03/08 15:16:35, dvyukov wrote:
> why do you need this lock?

There is no compare&swap in flushptrbuf(). flushptrbuf() uses the same
lock.

https://codereview.appspot.com/7473044/diff/1/src/pkg/runtime/mgc0.c#newcode1008
src/pkg/runtime/mgc0.c:1008: if(chan_ret == 0) {

On 2013/03/08 15:16:35, dvyukov wrote:
> s/0/nil/
> drop {}

Done.

https://codereview.appspot.com/7473044/

[dvy...@google.com]

LGTM generally, but I did not follow the GC changes very closely, so
better reviewed by somebody else as well.

https://codereview.appspot.com/7473044/