code review 5489099: builder: set default builder host to build.golang.org (issue 5489099)

8 views
Skip to first unread message

a...@golang.org

unread,
Dec 21, 2011, 1:01:53 AM12/21/11
to golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golan...@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go


Description:
builder: set default builder host to build.golang.org

Please review this at http://codereview.appspot.com/5489099/

Affected files:
M misc/dashboard/builder/main.go


Index: misc/dashboard/builder/main.go
===================================================================
--- a/misc/dashboard/builder/main.go
+++ b/misc/dashboard/builder/main.go
@@ -52,7 +52,7 @@
var (
buildroot = flag.String("buildroot",
path.Join(os.TempDir(), "gobuilder"), "Directory under which to build")
commitFlag = flag.Bool("commit", false, "upload information about new
commits")
- dashboard = flag.String("dashboard", "go-build.appspot.com", "Go
Dashboard Host")
+ dashboard = flag.String("dashboard", "build.golang.org", "Go
Dashboard Host")
buildRelease = flag.Bool("release", false, "Build and upload binary
release archives")
buildRevision = flag.String("rev", "", "Build specified revision and
exit")
buildCmd = flag.String("cmd", "./all.bash", "Build command (specify
absolute or relative to go/src/)")


Russ Cox

unread,
Dec 21, 2011, 1:03:16 AM12/21/11
to a...@golang.org, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
LGTM

a...@golang.org

unread,
Dec 21, 2011, 1:12:21 AM12/21/11
to a...@golang.org, golan...@googlegroups.com, r...@golang.org, re...@codereview-hr.appspotmail.com
*** Submitted as 4fcdedada20c ***

builder: set default builder host to build.golang.org

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5489099


http://codereview.appspot.com/5489099/

Reply all
Reply to author
Forward
0 new messages