Etiquette for getting a review of my change

[Nick White]

Hi gophers,

I have a CL [0] (my first), which I originally opened late 2022,
which got useful reviews, and then was put on hold while the
approach was hashed out more in the underlying issue [1]. That took
4 months, then consensus was reached. My life got busy and nothing
happened with this for almost 3 years. Then I made some time to sit
down and implement the new version as agreed in the issue, and
pushed it February 2026. But I have heard nothing since.

So I'd like to know the best etiquette to ask someone for a fresh
review, and move this forward. Maybe this message is it, maybe I
should add a comment on the Gerrit, or maybe I should just sit tight
and accept that the 1.5 months of silence is still rather less bad
than the 3 years it took me to get around to reworking this. The
gerrit CL is still marked as Hold, which I guess should be lifted
now, but I don't know if that's something I could or should do, or
if that's a determination that should be made by the person who put
it on hold.

Thanks all.

Nick

0: https://go-review.googlesource.com/c/go/+/445116
1: https://github.com/golang/go/issues/26715

[Ian Lance Taylor]

On Sun, Mar 22, 2026 at 1:44 AM Nick White <golan...@njw.name> wrote:
>
> Hi gophers,
>
> I have a CL [0] (my first), which I originally opened late 2022,
> which got useful reviews, and then was put on hold while the
> approach was hashed out more in the underlying issue [1]. That took
> 4 months, then consensus was reached. My life got busy and nothing
> happened with this for almost 3 years. Then I made some time to sit
> down and implement the new version as agreed in the issue, and
> pushed it February 2026. But I have heard nothing since.
>
> So I'd like to know the best etiquette to ask someone for a fresh
> review, and move this forward. Maybe this message is it, maybe I
> should add a comment on the Gerrit, or maybe I should just sit tight
> and accept that the 1.5 months of silence is still rather less bad
> than the 3 years it took me to get around to reworking this. The
> gerrit CL is still marked as Hold, which I guess should be lifted
> now, but I don't know if that's something I could or should do, or
> if that's a determination that should be made by the person who put
> it on hold.

It would be fine to ask for the CL to be taken off hold. I've asked
about that on the CL.

Ian

[Nick White]

On Sun, Mar 22, 2026 at 02:01:23AM -0700, Ian Lance Taylor wrote:
> It would be fine to ask for the CL to be taken off hold. I've asked
> about that on the CL.

That's great, thanks Ian.

Nick