code review 13067043: doc: describe halt_on_error race detector parameter (issue 13067043)

18 views
Skip to first unread message

dvy...@google.com

unread,
Aug 16, 2013, 2:23:56 PM8/16/13
to golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: golang-dev1,

Message:
Hello golan...@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40goog...@code.google.com/p/go/


Description:
doc: describe halt_on_error race detector parameter

Please review this at https://codereview.appspot.com/13067043/

Affected files:
M doc/articles/race_detector.html


Index: doc/articles/race_detector.html
===================================================================
--- a/doc/articles/race_detector.html
+++ b/doc/articles/race_detector.html
@@ -128,6 +128,11 @@
Increasing this value can avoid a "failed to restore the stack" error in
reports, at the
cost of increased memory usage.
</li>
+
+<li>
+<code>halt_on_error</code> (default <code>0</code>): Controls whether the
program
+exits after reporting first data race.
+</li>
</ul>

<p>


Brad Fitzpatrick

unread,
Aug 16, 2013, 2:41:52 PM8/16/13
to Dmitry Vyukov, golang-dev, re...@codereview-hr.appspotmail.com
LGTM



On Fri, Aug 16, 2013 at 11:23 AM, <dvy...@google.com> wrote:
Reviewers: golang-dev1,

Message:
Hello golan...@googlegroups.com,

I'd like you to review this change to



Description:
doc: describe halt_on_error race detector parameter

Please review this at https://codereview.appspot.com/13067043/

Affected files:
  M doc/articles/race_detector.html


Index: doc/articles/race_detector.html
===================================================================
--- a/doc/articles/race_detector.html
+++ b/doc/articles/race_detector.html
@@ -128,6 +128,11 @@
 Increasing this value can avoid a "failed to restore the stack" error in reports, at the
 cost of increased memory usage.
 </li>
+
+<li>
+<code>halt_on_error</code> (default <code>0</code>): Controls whether the program
+exits after reporting first data race.
+</li>
 </ul>

 <p>



--

---You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

dvy...@google.com

unread,
Aug 16, 2013, 2:43:05 PM8/16/13
to dvy...@google.com, golan...@googlegroups.com, brad...@golang.org, re...@codereview-hr.appspotmail.com
*** Submitted as
https://code.google.com/p/go/source/detail?r=49d897ab8e2f ***

doc: describe halt_on_error race detector parameter

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13067043


https://codereview.appspot.com/13067043/
Reply all
Reply to author
Forward
0 new messages