freebsd-amd64 broken by strconv/itoa: add test to generate the longest output string possible by formatBits

[bui...@golang.org]

Change 0668b595b604 broke the freebsd-amd64 build:
http://build.golang.org/log/845e5ad7f55f10150b77bbc780e84c57deaf2954

strconv/itoa: add test to generate the longest output string possible by
formatBits

The new test case produces the longest string representation possible and
thereby uses
all of the 65 bytes in the buffer array used by the formatBits function.

Change-Id: I11320c4de56ced5ff098b7e37f1be08e456573e2
Reviewed-on: https://go-review.googlesource.com/2108
Reviewed-by: Brad Fitzpatrick <brad...@golang.org>

http://code.google.com/p/go/source/detail?r=0668b595b604

$ tail -200 < log
goroutine 2 [force gc (idle)]:
runtime.gopark(0x69bcd8, 0x7583d0, 0x63b0b0, 0xf)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:151
+0x108 fp=0xc20801a798 sp=0xc20801a768
runtime.goparkunlock(0x7583d0, 0x63b0b0, 0xf)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:157 +0x48
fp=0xc20801a7c0 sp=0xc20801a798
runtime.forcegchelper()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:120 +0xce
fp=0xc20801a7e0 sp=0xc20801a7c0
runtime.goexit()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/asm_amd64.s:2405
+0x1 fp=0xc20801a7e8 sp=0xc20801a7e0
created by runtime.init·4
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:108 +0x33

goroutine 3 [GC sweep wait]:
runtime.gopark(0x69bcd8, 0x76b3c0, 0x634cb0, 0xd)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:151
+0x108 fp=0xc20801d798 sp=0xc20801d768
runtime.goparkunlock(0x76b3c0, 0x634cb0, 0xd)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:157 +0x48
fp=0xc20801d7c0 sp=0xc20801d798
runtime.bgsweep()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/mgc0.go:98 +0xdd
fp=0xc20801d7e0 sp=0xc20801d7c0
runtime.goexit()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/asm_amd64.s:2405
+0x1 fp=0xc20801d7e8 sp=0xc20801d7e0
created by runtime.gc
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/mgc.go:2042 +0xe66

goroutine 4 [finalizer wait]:
runtime.gopark(0x69bcd8, 0x76b3b8, 0x63a9b0, 0xe)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:151
+0x108 fp=0xc208018f30 sp=0xc208018f00
runtime.goparkunlock(0x76b3b8, 0x63a9b0, 0xe)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:157 +0x48
fp=0xc208018f58 sp=0xc208018f30
runtime.runfinq()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:913
+0xba fp=0xc208018fe0 sp=0xc208018f58
runtime.goexit()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/asm_amd64.s:2405
+0x1 fp=0xc208018fe8 sp=0xc208018fe0
created by runtime.createfing
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:893
+0x68

goroutine 17 [syscall]:
runtime.notetsleepg(0x758758, 0x8108f4a398, 0x0)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/lock_futex.go:198
+0x59 fp=0xc20801cf60 sp=0xc20801cf38
runtime.timerproc()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/time.go:210 +0xfa
fp=0xc20801cfe0 sp=0xc20801cf60
runtime.goexit()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/asm_amd64.s:2405
+0x1 fp=0xc20801cfe8 sp=0xc20801cfe0
created by runtime.addtimerLocked
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/time.go:116 +0x1c4

goroutine 42749 [semacquire]:
runtime.gopark(0x69bcd8, 0x75ba00, 0x63f650, 0xa)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:151
+0x108 fp=0xc208019408 sp=0xc2080193d8
runtime.goparkunlock(0x75ba00, 0x63f650, 0xa)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:157 +0x48
fp=0xc208019430 sp=0xc208019408
runtime.semacquire(0x741034, 0x0)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/sema.go:100
+0x22f fp=0xc208019468 sp=0xc208019430
runtime.gogc(0xc200000000)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:479
+0x9d fp=0xc2080194e0 sp=0xc208019468
runtime.mallocgc(0x50, 0x60dbc0, 0x0, 0x592f20)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:345
+0x3e5 fp=0xc2080195f0 sp=0xc2080194e0
runtime.newobject(0x60dbc0, 0xc2080ca9d8)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:387
+0x49 fp=0xc208019618 sp=0xc2080195f0
reflect.mapiterinit(0x591820, 0xc208044420, 0x15)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/hashmap.go:939
+0x2a fp=0xc208019640 sp=0xc208019618
reflect.Value.MapKeys(0x591820, 0xc208044420, 0x15, 0x0, 0x0, 0x0)
/usr/local/go/src/reflect/value.go:1039 +0xf9 fp=0xc2080196e8
sp=0xc208019640
runtime_test.func·058()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/map_test.go:270
+0xb3 fp=0xc2080197e0 sp=0xc2080196e8
runtime.goexit()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/asm_amd64.s:2405
+0x1 fp=0xc2080197e8 sp=0xc2080197e0
created by runtime_test.testConcurrentReadsAfterGrowth
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/map_test.go:274
+0x3a5

goroutine 574 [syscall]:
runtime_test.func·047(0x0, 0x4e94914f0000, 0x64e7d0, 0x14, 0xc20804e060)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/futex_test.go:47
+0x2d fp=0xc208017fb8 sp=0xc208017f70
runtime.goexit()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/asm_amd64.s:2405
+0x1 fp=0xc208017fc0 sp=0xc208017fb8
created by runtime_test.TestFutexsleep
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/futex_test.go:51
+0x23a

goroutine 32632 [semacquire]:
runtime.gopark(0x69bcd8, 0x75c6c0, 0x63f650, 0xa)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:151
+0x108 fp=0xc208079638 sp=0xc208079608
runtime.goparkunlock(0x75c6c0, 0x63f650, 0xa)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:157 +0x48
fp=0xc208079660 sp=0xc208079638
runtime.semacquire(0xc208199e00, 0xc208199e01)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/sema.go:100
+0x22f fp=0xc208079698 sp=0xc208079660
sync.runtime_Semacquire(0xc208199e00)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/sema.go:43 +0x2d
fp=0xc2080796b0 sp=0xc208079698
sync.(*WaitGroup).Wait(0xc2080f7d80)
/usr/local/go/src/sync/waitgroup.go:132 +0x169 fp=0xc2080796d8
sp=0xc2080796b0
runtime_test.testConcurrentReadsAfterGrowth(0xc208080120, 0x758701)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/map_test.go:277
+0x3ce fp=0xc208079760 sp=0xc2080796d8
runtime_test.TestConcurrentReadsAfterGrowthReflect(0xc208080120)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/map_test.go:287
+0x2d fp=0xc208079778 sp=0xc208079760
testing.tRunner(0xc208080120, 0x756350)
/usr/local/go/src/testing/testing.go:447 +0xc6 fp=0xc2080797d0
sp=0xc208079778
runtime.goexit()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/asm_amd64.s:2405
+0x1 fp=0xc2080797d8 sp=0xc2080797d0
created by testing.RunTests
/usr/local/go/src/testing/testing.go:555 +0xa96

goroutine 575 [syscall]:
runtime_test.func·047(0x0, 0x1dcd65174876e800, 0x64e210, 0x13, 0xc20804e0c0)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/futex_test.go:47
+0x2d fp=0xc20801bfb8 sp=0xc20801bf70
runtime.goexit()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/asm_amd64.s:2405
+0x1 fp=0xc20801bfc0 sp=0xc20801bfb8
created by runtime_test.TestFutexsleep
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/futex_test.go:51
+0x23a

goroutine 42743 [garbage collection]:
runtime.systemstack_switch()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/asm_amd64.s:199
fp=0xc208076c90 sp=0xc208076c88
runtime.gogc(0xc200000000)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:549
+0x323 fp=0xc208076d08 sp=0xc208076c90
runtime.mallocgc(0x20, 0x621d20, 0xc200000000, 0x8)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:345
+0x3e5 fp=0xc208076e18 sp=0xc208076d08
runtime.newobject(0x621d20, 0xc2081180d8)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:387
+0x49 fp=0xc208076e40 sp=0xc208076e18
reflect.Value.MapIndex(0x591820, 0xc208044420, 0x15, 0x592f20,
0xc2080ddc88, 0x42, 0x592f20, 0xc2080ca318, 0x42)
/usr/local/go/src/reflect/value.go:986 +0x32 fp=0xc208076ee8
sp=0xc208076e40
runtime_test.func·058()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/map_test.go:272
+0x193 fp=0xc208076fe0 sp=0xc208076ee8
runtime.goexit()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/asm_amd64.s:2405
+0x1 fp=0xc208076fe8 sp=0xc208076fe0
created by runtime_test.testConcurrentReadsAfterGrowth
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/map_test.go:274
+0x3a5

goroutine 42755 [semacquire]:
runtime.gopark(0x69bcd8, 0x75ba00, 0x63f650, 0xa)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:151
+0x108 fp=0xc2080e7c08 sp=0xc2080e7bd8
runtime.goparkunlock(0x75ba00, 0x63f650, 0xa)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:157 +0x48
fp=0xc2080e7c30 sp=0xc2080e7c08
runtime.semacquire(0x741034, 0x410500)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/sema.go:100
+0x22f fp=0xc2080e7c68 sp=0xc2080e7c30
runtime.gogc(0xc200000000)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:479
+0x9d fp=0xc2080e7ce0 sp=0xc2080e7c68
runtime.mallocgc(0x50, 0x60dbc0, 0x0, 0x592f20)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:345
+0x3e5 fp=0xc2080e7df0 sp=0xc2080e7ce0
runtime.newobject(0x60dbc0, 0xc2080fa6f0)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:387
+0x49 fp=0xc2080e7e18 sp=0xc2080e7df0
reflect.mapiterinit(0x591820, 0xc208044420, 0x15)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/hashmap.go:939
+0x2a fp=0xc2080e7e40 sp=0xc2080e7e18
reflect.Value.MapKeys(0x591820, 0xc208044420, 0x15, 0x0, 0x0, 0x0)
/usr/local/go/src/reflect/value.go:1039 +0xf9 fp=0xc2080e7ee8
sp=0xc2080e7e40
runtime_test.func·058()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/map_test.go:270
+0xb3 fp=0xc2080e7fe0 sp=0xc2080e7ee8
runtime.goexit()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/asm_amd64.s:2405
+0x1 fp=0xc2080e7fe8 sp=0xc2080e7fe0
created by runtime_test.testConcurrentReadsAfterGrowth
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/map_test.go:274
+0x3a5

goroutine 42746 [semacquire]:
runtime.gopark(0x69bcd8, 0x75ba00, 0x63f650, 0xa)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:151
+0x108 fp=0xc20801dc08 sp=0xc20801dbd8
runtime.goparkunlock(0x75ba00, 0x63f650, 0xa)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:157 +0x48
fp=0xc20801dc30 sp=0xc20801dc08
runtime.semacquire(0x741034, 0x410500)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/sema.go:100
+0x22f fp=0xc20801dc68 sp=0xc20801dc30
runtime.gogc(0xc200000000)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:479
+0x9d fp=0xc20801dce0 sp=0xc20801dc68
runtime.mallocgc(0x50, 0x60dbc0, 0x0, 0x592f20)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:345
+0x3e5 fp=0xc20801ddf0 sp=0xc20801dce0
runtime.newobject(0x60dbc0, 0xc2080a1480)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:387
+0x49 fp=0xc20801de18 sp=0xc20801ddf0
reflect.mapiterinit(0x591820, 0xc208044420, 0x15)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/hashmap.go:939
+0x2a fp=0xc20801de40 sp=0xc20801de18
reflect.Value.MapKeys(0x591820, 0xc208044420, 0x15, 0x0, 0x0, 0x0)
/usr/local/go/src/reflect/value.go:1039 +0xf9 fp=0xc20801dee8
sp=0xc20801de40
runtime_test.func·058()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/map_test.go:270
+0xb3 fp=0xc20801dfe0 sp=0xc20801dee8
runtime.goexit()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/asm_amd64.s:2405
+0x1 fp=0xc20801dfe8 sp=0xc20801dfe0
created by runtime_test.testConcurrentReadsAfterGrowth
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/map_test.go:274
+0x3a5

goroutine 42752 [semacquire]:
runtime.gopark(0x69bcd8, 0x75ba00, 0x63f650, 0xa)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:151
+0x108 fp=0xc2080e1408 sp=0xc2080e13d8
runtime.goparkunlock(0x75ba00, 0x63f650, 0xa)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/proc.go:157 +0x48
fp=0xc2080e1430 sp=0xc2080e1408
runtime.semacquire(0x741034, 0x410500)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/sema.go:100
+0x22f fp=0xc2080e1468 sp=0xc2080e1430
runtime.gogc(0xc200000000)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:479
+0x9d fp=0xc2080e14e0 sp=0xc2080e1468
runtime.mallocgc(0x50, 0x60dbc0, 0x0, 0x592f20)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:345
+0x3e5 fp=0xc2080e15f0 sp=0xc2080e14e0
runtime.newobject(0x60dbc0, 0xc2081561a0)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/malloc.go:387
+0x49 fp=0xc2080e1618 sp=0xc2080e15f0
reflect.mapiterinit(0x591820, 0xc208044420, 0x15)
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/hashmap.go:939
+0x2a fp=0xc2080e1640 sp=0xc2080e1618
reflect.Value.MapKeys(0x591820, 0xc208044420, 0x15, 0x0, 0x0, 0x0)
/usr/local/go/src/reflect/value.go:1039 +0xf9 fp=0xc2080e16e8
sp=0xc2080e1640
runtime_test.func·058()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/map_test.go:270
+0xb3 fp=0xc2080e17e0 sp=0xc2080e16e8
runtime.goexit()
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/asm_amd64.s:2405
+0x1 fp=0xc2080e17e8 sp=0xc2080e17e0
created by runtime_test.testConcurrentReadsAfterGrowth
/tmp/gobuilder/freebsd-amd64-0668b595b604/go/src/runtime/map_test.go:274
+0x3a5
FAIL runtime 51.837s
Build complete, duration 5m24.629552869s. Result: error: exit status 1