Help - cl 362834 stuck in review (http/2 performance issue)

[Jean-François Giorgi]

hi

This CL https://go-review.googlesource.com/c/net/+/362834 is stuck in review since december 2021.

It's related to https://github.com/golang/go/issues/47840

Any hope/info about the evolution of this ?

I'm not familiar with how CLs/issues are handled. 

Do we have to assume that CLs/issues that are ignored for months = wontfix  or just that the waiting queue is too big ?

Thx

[Jenny Rakoczy]

Hi Jean-François,

It looks like comments were left on the CL and we are waiting for a response from the author. I'm not sure what you mean by ignored, it seems like it's gotten appropriate attention. In order to ensure the quality and stability of Go releases, it's important to see all comments resolved before merging a CL.

If this issue is important to you, it may be appropriate to send a new change if you're familiar with the issue.

Thanks,

Jenny

[Jean-François Giorgi]

Hi,

Well according to CL author , it's stuck in review ( see https://github.com/golang/go/issues/47840#issuecomment-1132324051 )

May be there has been a misunderstanding between them ? I'll inform the author.

The proposed change is good, it solves partially the performance issue so no point sending the same CL again I guess ?

Thx

[Robert Engels]

As the author it got stuck because it seemed the scope wanted to be increased. I think the CL is fine as it is and additional CLs can be created to address other concerns. 

On Aug 31, 2022, at 2:45 PM, Jean-François Giorgi <jfgi...@gmail.com> wrote:

Hi,

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/6f7b70c0-fed1-4918-bd17-9f28a9dff2a6n%40googlegroups.com.

[Jean-François Giorgi]

Hi and thanks for replying.

> I think the CL is fine as it is and additional CLs can be created to address other concerns. 

exactly what I understood.

So how can we proceed to get the CL accepted ? do you have to close the unresolved comments or can anyone do it ? . 
thx

[Jenny Rakoczy]

Hi Robert,

Would you mind replying on the CL so the appropriate reviewers see your response?

Thanks,

Jenny

[robert engels]

I have updated the CL and comments.

Best,

Robert

To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/98188a5d-7371-4dc2-ad07-54ddb176725bn%40googlegroups.com.