Should os.Chmod accept os.FileMode?

[Evan Shaw]

I was just updating some code and this came up. It seems silly to
require a conversion in this code:

info, _ := os.Stat(path)
os.Chmod(path, uint32(info.Mode()|0111))

Is there any reason not to change os.Chmod? I couldn't find any
previous discussion. os.OpenFile has the same issue.

- Evan

[Ian Lance Taylor]

Evan Shaw <eds...@gmail.com> writes:

The current definition of os.Chmod permits the program to set the sticky
bit (01000). Changing the second parameter to FileMode as it stands
today would not permit that. I think that would have to be addressed
one way or another.

Ian

[Evan Shaw]

On Sun, Jan 15, 2012 at 6:16 AM, Ian Lance Taylor <ia...@google.com> wrote:
> The current definition of os.Chmod permits the program to set the sticky
> bit (01000).  Changing the second parameter to FileMode as it stands
> today would not permit that.  I think that would have to be addressed
> one way or another.

Is it just because there's no defined constant for the sticky bit?
Right now one can use an integer literal and it's easy to add a
constant, so I must be missing something.

- Evan

[Ian Lance Taylor]

Evan Shaw <eds...@gmail.com> writes:

In your example of

os.Chmod(path, uint32(info.Mode()|0111))

the sticky bit would be unintentionally cleared.

It's fixable, it just has to be done.

Ian

[Rob 'Commander' Pike]

Not very sticky then, is it?

-rob

[Russ Cox]

Yes, I think Chmod and the others should take a FileMode.

Russ

[Brad Fitzpatrick]

is this a Go 1 thing? is there a bug?

[Evan Shaw]

On Thu, Jan 19, 2012 at 2:33 PM, Brad Fitzpatrick <brad...@google.com> wrote:
> is this a Go 1 thing? is there a bug?

It's a Go 1 thing and there's no bug as far as I know.

- Evan

[Brad Fitzpatrick]

Want to file one?

[Evan Shaw]

On Thu, Jan 19, 2012 at 2:59 PM, Brad Fitzpatrick <brad...@golang.org> wrote:
> Want to file one?

Done: http://code.google.com/p/go/issues/detail?id=2733

- Evan