code review 28630043: gosshnew/ssh: drop redundant window update in test. (issue 28630043)

[han...@google.com]

Reviewers: agl1, dfc, jpsugar,

Message:
Hello agl1, da...@cheney.net, jps...@google.com (cc: a...@golang.org,
da...@cheney.net, golan...@googlegroups.com, han...@google.com,
jps...@google.com),

I'd like you to review this change to
https://hanwen%40goog...@code.google.com/p/gosshnew/


Description:
gosshnew/ssh: drop redundant window update in test.

Please review this at https://codereview.appspot.com/28630043/

Affected files (+0, -4 lines):
M ssh/session_test.go


Index: ssh/session_test.go
===================================================================
--- a/ssh/session_test.go
+++ b/ssh/session_test.go
@@ -533,10 +533,6 @@

func discardHandler(ch *channel, t *testing.T) {
defer ch.Close()
- // grow the window to avoid being fooled by
- // the initial 1 << 14 window.
- ch.adjustWindow(1024 * 1024)
-
io.Copy(ioutil.Discard, ch)
}

[Dave Cheney]

I can't remember why I added that line, but there was probably a reason. It may not be important now as the semantics of the channel api have changed, but I'd like some time to review the commit log to remind myself.

[Han-Wen Nienhuys]

On Tue, Nov 19, 2013 at 12:14 PM, Dave Cheney <da...@cheney.net> wrote:
> I can't remember why I added that line, but there was probably a reason. It may not be important now as the semantics of the channel api have changed, but I'd like some time to review the commit log to remind myself.

https://codereview.appspot.com/6448128/

I think it's obsolete now that we start with a 2M window.




--
Han-Wen Nienhuys
Google Munich
han...@google.com

[Dave Cheney]

Fair point. LGTM.

[han...@google.com]

*** Submitted as
https://code.google.com/p/gosshnew/source/detail?r=925b07ad2f79 ***

gosshnew/ssh: drop redundant window update in test.

R=agl, dave, jpsugar
CC=agl, dave, golang-dev, hanwen, jpsugar
https://codereview.appspot.com/28630043


https://codereview.appspot.com/28630043/