code review 9438043: rsa: Implementation of RSASSA-PSS signature algorithm a... (issue 9438043)

127 views
Skip to first unread message

mon...@gmail.com

unread,
May 15, 2013, 6:01:31 PM5/15/13
to golan...@googlegroups.com, a...@golang.org, re...@codereview-hr.appspotmail.com
Reviewers: golang-dev1,

Message:
Hello golan...@googlegroups.com (cc: a...@golang.org),

I'd like you to review this change to
https://code.google.com/p/go


Description:
rsa: Implementation of RSASSA-PSS signature algorithm and its
corresponding test cases

Implementation of RSASSA-PSS signature algorithm described in RFC 3447
and its corresponding test cases.

There are two test files:
- emsa_test.go: Test on EMSA-PSS encoding/decoding scheme
- pssvect_test.go: Test on the signature algorithm itself. All cases are
generated from the test vectors provided by RSA Lab, which can be
downloaded from
ftp://ftp.rsasecurity.com/pub/pkcs/pkcs-1/pkcs-1v2-1-vec.zip

Please review this at https://codereview.appspot.com/9438043/

Affected files:
A src/pkg/crypto/rsa/emsa_test.go
A src/pkg/crypto/rsa/pss.go
A src/pkg/crypto/rsa/pssvect_test.go


r...@golang.org

unread,
May 15, 2013, 6:04:02 PM5/15/13
to mon...@gmail.com, golan...@googlegroups.com, a...@golang.org, re...@codereview-hr.appspotmail.com
Does this need to be in the main repo? The go.crypt repo seems fine to
ignorant me.


https://codereview.appspot.com/9438043/

mon...@gmail.com

unread,
May 15, 2013, 6:14:40 PM5/15/13
to golan...@googlegroups.com, r...@golang.org, a...@golang.org, re...@codereview-hr.appspotmail.com
In rsa.go, line 8, there is a TODO says " TODO(agl): Add support for PSS
padding." So I submit this CL to the main repo.

To me, putting these functions to anywhere would be OK. Do I need to
submit another CL to go.crypto repo?

go...@golang.org

unread,
May 16, 2013, 6:13:20 AM5/16/13
to mon...@gmail.com, a...@chromium.org, a...@golang.org, golan...@googlegroups.com, r...@golang.org, re...@codereview-hr.appspotmail.com
R=agl (assigned by minux)

https://codereview.appspot.com/9438043/
Reply all
Reply to author
Forward
0 new messages