next steps on PR 362834?

[robert engels]

Hi,

Is there anything else that needs to be done to get 362834 accepted? I believe all concerns/bugs have been addressed.

Thanks,

Robert

[Ian Lance Taylor]

On Tue, Nov 16, 2021 at 10:57 AM robert engels <ren...@ix.netcom.com> wrote:
>
> Is there anything else that needs to be done to get 362834 accepted? I believe all concerns/bugs have been addressed.

1) This is an API addition, and as such should normally go through the
proposal process (https://golang.org/s/proposal-process). Want to
open a proposal for this?

2) We are in our release freeze now
(https://golang.org/wiki/Go-Release-Cycle) so this will most likely
have to wait until 1.19 anyhow.

Thanks.

Ian

[ren...@ix.netcom.com]

Isn't this an API bug? According to the Http2 spec this should of been implemented, see 4.2 and 6.5.2.

More importantly or confusingly, this is part of the 'golang.org/x' package - isn't this designed just for this purpose - to get issues like this corrected quickly - since there are no guarantees of backwards compatibility when using 'golang.org/x'.

[Ian Lance Taylor]

On Tue, Nov 16, 2021 at 12:35 PM ren...@ix.netcom.com
<ren...@ix.netcom.com> wrote:
>
> Isn't this an API bug? According to the Http2 spec this should of been implemented, see 4.2 and 6.5.2.
>
> More importantly or confusingly, this is part of the 'golang.org/x' package - isn't this designed just for this purpose - to get issues like this corrected quickly - since there are no guarantees of backwards compatibility when using 'golang.org/x'.

This may well be an API bug, I don't know.

The various x/ packages have different compatibility requirements.
The x/net/http2 package becomes part of the standard library's
net/http package, so it is subject to the same compatibility
requirements as the standard library.

That said I see now that this new exported field in a struct that is
not exported by the net/http package, so maybe there is no Go API
issue here. I'm not sure.

I'll leave this for Damien. We are all extremely overloaded due to
entering the release freeze, and the last comments on the CL were only
yesterday. Please be patient. Thanks.

Ian

> On Tuesday, November 16, 2021 at 1:58:29 PM UTC-6 Ian Lance Taylor wrote:
>>
>> On Tue, Nov 16, 2021 at 10:57 AM robert engels <ren...@ix.netcom.com> wrote:
>> >
>> > Is there anything else that needs to be done to get 362834 accepted? I believe all concerns/bugs have been addressed.
>>
>> 1) This is an API addition, and as such should normally go through the
>> proposal process (https://golang.org/s/proposal-process). Want to
>> open a proposal for this?
>>
>> 2) We are in our release freeze now
>> (https://golang.org/wiki/Go-Release-Cycle) so this will most likely
>> have to wait until 1.19 anyhow.
>>
>> Thanks.
>>
>> Ian
>

> --
> You received this message because you are subscribed to the Google Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/60a2e41b-fa3b-414e-95be-7e90c68860cbn%40googlegroups.com.

[robert engels]

No worries. Thanks. It was only that the first comments regarding the lack of tests, etc. came very quickly so I rushed to get those addressed and then I didn’t hear anything - so I wasn’t fully certain there wasn’t something else I needed to do.

> You received this message because you are subscribed to a topic in the Google Groups "golang-dev" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/topic/golang-dev/nRkRS9161-4/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to golang-dev+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/CAOyqgcU49HMcBMjtUPwtQmWbBsU58WRNA27pmtJUBrx6dEq9Ng%40mail.gmail.com.