code review 6631054: misc/cgo/test: add -ldl to LDFLAGS on Linux, ignore iss... (issue 6631054)

[minu...@gmail.com]

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golan...@googlegroups.com (cc: golan...@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/


Description:
misc/cgo/test: add -ldl to LDFLAGS on Linux, ignore issue4029 on windows
(fix build)

Please review this at http://codereview.appspot.com/6631054/

Affected files:
M misc/cgo/test/issue4029.go
A misc/cgo/test/issue4029w.go


Index: misc/cgo/test/issue4029.go
===================================================================
--- a/misc/cgo/test/issue4029.go
+++ b/misc/cgo/test/issue4029.go
@@ -2,10 +2,13 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

+// +build !windows
+
package cgotest

/*
#include <dlfcn.h>
+#cgo linux LDFLAGS: -ldl
*/
import "C"

Index: misc/cgo/test/issue4029w.go
===================================================================
new file mode 100644
--- /dev/null
+++ b/misc/cgo/test/issue4029w.go
@@ -0,0 +1,12 @@
+// Copyright 2012 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// +build windows
+
+package cgotest
+
+import "testing"
+
+func test4029(t *testing.T) {
+}

[minu...@gmail.com]

*** Submitted as
http://code.google.com/p/go/source/detail?r=3787ef7b4700 ***

misc/cgo/test: add -ldl to LDFLAGS on Linux, ignore issue4029 on windows
(fix build)

R=golang-dev
CC=golang-dev
http://codereview.appspot.com/6631054


http://codereview.appspot.com/6631054/