code review 10914045: misc/cgo/test: skip test for issue 3250, the runtime is... (issue 10914045)

29 views
Skip to first unread message

minu...@gmail.com

unread,
Jul 14, 2013, 3:22:19 PM7/14/13
to golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: golang-dev1,

Message:
Hello golan...@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/


Description:
misc/cgo/test: skip test for issue 3250, the runtime isn't ready yet.
see issue 5885.

Please review this at https://codereview.appspot.com/10914045/

Affected files:
M misc/cgo/test/issue3250.go


Index: misc/cgo/test/issue3250.go
===================================================================
--- a/misc/cgo/test/issue3250.go
+++ b/misc/cgo/test/issue3250.go
@@ -45,6 +45,7 @@
)

func test3250(t *testing.T) {
+ t.Skip("skipped, see golang.org/issue/5885")
const (
thres = 1
sig = syscall.SIGCHLD


minu...@gmail.com

unread,
Jul 14, 2013, 3:23:05 PM7/14/13
to golan...@googlegroups.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com

ia...@golang.org

unread,
Jul 14, 2013, 5:16:33 PM7/14/13
to minu...@gmail.com, golan...@googlegroups.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com

minu...@gmail.com

unread,
Jul 15, 2013, 2:37:50 AM7/15/13
to minu...@gmail.com, golan...@googlegroups.com, ia...@golang.org, re...@codereview-hr.appspotmail.com
*** Submitted as
https://code.google.com/p/go/source/detail?r=61b8f10038ed ***

misc/cgo/test: skip test for issue 3250, the runtime isn't ready yet.
see issue 5885.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/10914045


https://codereview.appspot.com/10914045/
Reply all
Reply to author
Forward
0 new messages