Firstime contributor questions

Anthony Canino

unread,

Aug 21, 2015, 9:56:30 AM8/21/15

to golang-dev

Hi all, I have a couple quick questions about contributing to go. I apologize if this is not the right place for this.

1. In the context of bug fixes, should I have a discussion with someone first before submitting a CL or should I submit a CL if I believe I have fixed a bug and all tests have passed?

2. Is it preferable to email golang-dev to have a discussion about fixing a certain bug or to post on the issue on github?

Appreciate the time,

Anthony.

Andrew Gerrand

unread,

Aug 21, 2015, 10:05:58 AM8/21/15

to Anthony Canino, golang-dev

On 21 August 2015 at 12:42, Anthony Canino <anthony...@gmail.com> wrote:

Hi all, I have a couple quick questions about contributing to go. I apologize if this is not the right place for this.

This is the right place. Thanks for your interest in contributing to Go! :-)

1. In the context of bug fixes, should I have a discussion with someone first before submitting a CL or should I submit a CL if I believe I have fixed a bug and all tests have passed?

If it's a simple bug with an unambiguous solution, then just go ahead and mail a CL. Don't forget the "Fixes #NNNN" line in the CL description.

2. Is it preferable to email golang-dev to have a discussion about fixing a certain bug or to post on the issue on github?

Better to discuss it on the GitHub issue thread.

Andrew

Anthony Canino

unread,

Aug 21, 2015, 10:26:24 AM8/21/15

to Andrew Gerrand, golang-dev

Great, thanks Andrew. Looking forward to contributing.

Anthony

--

Anthony

Reply all

Reply to author

Forward