code review 22890043: gosshnew/ssh: require a hostkey for the server handshake. (issue 22890043)

[han...@google.com]

Reviewers: agl1, dfc, jpsugar,

Message:
Hello agl1, dfc, jps...@google.com (cc: a...@golang.org, d...@golang.org,
golan...@googlegroups.com, han...@google.com),

I'd like you to review this change to
https://hanwen%40goog...@code.google.com/p/gosshnew/


Description:
gosshnew/ssh: require a hostkey for the server handshake.

Please review this at https://codereview.appspot.com/22890043/

Affected files (+4, -0 lines):
M ssh/server.go


Index: ssh/server.go
===================================================================
--- a/ssh/server.go
+++ b/ssh/server.go
@@ -142,6 +142,10 @@

// Handshake performs an SSH transport and client authentication on the
given ServerConn.
func (s *ServerConn) Handshake() error {
+ if len(s.config.hostKeys) == 0 {
+ return errors.New("ssh: server has no host keys")
+ }
+
var err error
s.serverVersion = []byte(packageVersion)
s.ClientVersion, err = exchangeVersions(s.sshConn.conn, s.serverVersion)

[jps...@google.com]

LGTM

https://codereview.appspot.com/22890043/

[han...@google.com]

*** Submitted as
https://code.google.com/p/gosshnew/source/detail?r=9cdf2c59c9d7 ***

gosshnew/ssh: require a hostkey for the server handshake.

R=agl, dave, jpsugar
CC=agl, dfc, golang-dev, hanwen
https://codereview.appspot.com/22890043


https://codereview.appspot.com/22890043/