Re: code review 13760044: all: Fix a couple of issues reported by go vet. (issue 13760044)

r...@golang.org

unread,

Sep 25, 2013, 11:04:27 PM9/25/13

to r.ekl...@gmail.com, golan...@googlegroups.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com

LGTM

but apologies for the delay and what it causes - please sync to tip and
upload again so i can patch it for submission.

-rob

https://codereview.appspot.com/13760044/

r.ekl...@gmail.com

unread,

Sep 27, 2013, 11:35:26 AM9/27/13

to golan...@googlegroups.com, r...@golang.org, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com

On 2013/09/26 03:04:27, r wrote:
> LGTM

> but apologies for the delay and what it causes - please sync to tip
and upload
> again so i can patch it for submission.

> -rob

No worries. Rev 28fb312f69c445cc1f8c23eab856da9ce481b9d8 applied all but
one chunk. I have changed laptop since last time, so I'm not sure how to
submit to this CL. For now I will create a new CL at
https://codereview.appspot.com/14038044

Just out of curiosity, how would I continue on this CL after switching
laptops?

https://codereview.appspot.com/13760044/

Rob Pike

unread,

Sep 27, 2013, 4:47:45 PM9/27/13

to r.ekl...@gmail.com, golan...@googlegroups.com, r...@golang.org, re...@codereview-hr.appspotmail.com

Just hg clpatch the old CL number on the new machine, but if there was still a chunk mismatch that would be a problem....

-rob

Reply all

Reply to author

Forward