code review 43620043: A+C: Nicolas Antonius Ernst Leopold Maria Kaiser (indiv... (issue 43620043)

25 views
Skip to first unread message

a...@golang.org

unread,
Dec 17, 2013, 5:03:44 PM12/17/13
to go...@swtch.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: gobot_swtch.com,

Message:
Hello go...@swtch.com (cc: golan...@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
A+C: Nicolas Antonius Ernst Leopold Maria Kaiser (individual CLA)

Generated by addca.

Please review this at https://codereview.appspot.com/43620043/

Affected files (+2, -0 lines):
M AUTHORS
M CONTRIBUTORS


Index: AUTHORS
===================================================================
--- a/AUTHORS
+++ b/AUTHORS
@@ -253,6 +253,7 @@
Nicholas Sullivan <nicholas...@gmail.com>
Nicholas Waples <nwa...@gmail.com>
Nick Craig-Wood <ni...@craig-wood.com> <nic...@gmail.com>
+Nicolas Antonius Ernst Leopold Maria Kaiser <ni...@nikai.net>
Nicolas Owens <misc...@offblast.org>
Nigel Kerr <nigel...@gmail.com>
Noah Campbell <noahca...@gmail.com>
Index: CONTRIBUTORS
===================================================================
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -367,6 +367,7 @@
Nicholas Sullivan <nicholas...@gmail.com>
Nicholas Waples <nwa...@gmail.com>
Nick Craig-Wood <ni...@craig-wood.com> <nic...@gmail.com>
+Nicolas Antonius Ernst Leopold Maria Kaiser <ni...@nikai.net>
Nicolas Owens <misc...@offblast.org>
Nigel Kerr <nigel...@gmail.com>
Nigel Tao <nige...@golang.org>


Andrew Gerrand

unread,
Dec 17, 2013, 5:05:41 PM12/17/13
to go...@swtch.com, ni...@nikai.net, golang-dev, re...@codereview-hr.appspotmail.com
Hi Nicolas,

We're adding you to the Go project's AUTHORS and CONTRIBUTORS files, as you contributed a fix to the goimports repository that is being migrated from bradfitz's GitHub to the Go project itself.

Do you mind if we just use your first and last names? Or would you prefer to go the whole hog here? :-)

Andrew

Nicolas Kaiser

unread,
Dec 17, 2013, 6:27:10 PM12/17/13
to Andrew Gerrand, golang-dev, re...@codereview-hr.appspotmail.com
* Andrew Gerrand <a...@golang.org>:
> We're adding you to the Go project's AUTHORS and CONTRIBUTORS files, as you
> contributed a fix to the goimports repository that is being migrated from
> bradfitz's GitHub to the Go project itself.

Thanks!

> Do you mind if we just use your first and last names? Or would you prefer
> to go the whole hog here? :-)

No problem, I'd prefer you just use my first and last names.

Best regards,
Nicolas Kaiser

a...@golang.org

unread,
Dec 17, 2013, 11:48:11 PM12/17/13
to a...@golang.org, go...@swtch.com, ni...@nikai.net, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
*** Submitted as
https://code.google.com/p/go/source/detail?r=878fc73cc5e4 ***

A+C: Nicolas Antonius Ernst Leopold Maria Kaiser (individual CLA)

Generated by addca.

R=gobot, nikai
CC=golang-dev
https://codereview.appspot.com/43620043


https://codereview.appspot.com/43620043/

Andrew Gerrand

unread,
Dec 17, 2013, 11:47:56 PM12/17/13
to Nicolas Kaiser, golang-dev, re...@codereview-hr.appspotmail.com
Cheers. Thanks for getting back to us so quickly.​
Reply all
Reply to author
Forward
0 new messages