code review 6810093: net: fix protocol number for IPv6 test (issue 6810093)

46 views
Skip to first unread message

mikioh...@gmail.com

unread,
Nov 7, 2012, 5:15:36 AM11/7/12
to golan...@googlegroups.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golan...@googlegroups.com (cc: golan...@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
net: fix protocol number for IPv6 test

The protocol number of ICMP for IPv6 is 58, not 1.

Please review this at http://codereview.appspot.com/6810093/

Affected files:
M src/pkg/net/ipraw_test.go


Index: src/pkg/net/ipraw_test.go
===================================================================
--- a/src/pkg/net/ipraw_test.go
+++ b/src/pkg/net/ipraw_test.go
@@ -21,7 +21,7 @@
ipv6 bool // test with underlying AF_INET6 socket
}{
{"ip4:icmp", "", "127.0.0.1", false},
- {"ip6:icmp", "", "::1", true},
+ {"ip6:ipv6-icmp", "", "::1", true},
}

func TestICMP(t *testing.T) {


Brad Fitzpatrick

unread,
Nov 7, 2012, 7:29:33 AM11/7/12
to mikioh...@gmail.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
LGTM

mikioh...@gmail.com

unread,
Nov 7, 2012, 7:55:38 AM11/7/12
to mikioh...@gmail.com, golan...@googlegroups.com, brad...@golang.org, re...@codereview-hr.appspotmail.com
*** Submitted as
http://code.google.com/p/go/source/detail?r=e1d0c77a3cd5 ***

net: fix protocol number for IPv6 test

The protocol number of ICMP for IPv6 is 58, not 1.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6810093


http://codereview.appspot.com/6810093/
Reply all
Reply to author
Forward
0 new messages