linux-arm-panda broken by testing: add Skip/Skipf

7 views
Skip to first unread message

bui...@golang.org

unread,
Jan 22, 2013, 6:37:59 PM1/22/13
to golan...@googlegroups.com
Change 0aa3f72c1c8b broke the linux-arm-panda build:
http://build.golang.org/log/a6bee60a182e376da83ade955655dc08d20ded37

testing: add Skip/Skipf

This proposal adds two methods to *testing.T, Skip(string) and
Skipf(format, args...). The intent is to replace the existing log and
return idiom which currently has 97 cases in the standard library. A simple
example of Skip would be:

func TestSomethingLong(t *testing.T) {
if testing.Short() {
t.Skip("skipping test in short mode.")
// not reached
}
... time consuming work
}

Additionally tests can be skipped anywhe

http://code.google.com/p/go/source/detail?r=0aa3f72c1c8b

$ tail -200 < log
database/sql/driver
database/sql
debug/gosym
encoding/ascii85
encoding/base32
encoding/csv
exp/cookiejar
exp/ebnf
go/types
exp/ebnflint
exp/html/atom
exp/html
exp/gotype
exp/inotify
exp/norm
exp/locale/collate
hash/fnv
exp/utf8string
hash/crc64
image/color
image
image/draw
image/gif
image/jpeg
image/png
log/syslog
math/cmplx
net/http/cgi
net/http/fcgi
net/http/httptest
net/http/httputil
net/mail
net/rpc
net/rpc/jsonrpc
exp/locale/collate/build
exp/locale/collate/tools/colcmp
net/smtp
old/netchan
os/user
runtime/debug
testing
testing/iotest
testing/quick

# Testing packages.
ok cmd/api 0.078s
? cmd/cgo [no test files]
ok cmd/fix 10.517s
ok cmd/go 0.097s
? cmd/godoc [no test files]
ok cmd/gofmt 0.219s
? cmd/vet [no test files]
? cmd/yacc [no test files]
ok archive/tar 0.043s
ok archive/zip 0.306s
ok bufio 0.291s
ok bytes 0.935s
ok compress/bzip2 0.462s
ok compress/flate 3.580s
ok compress/gzip 0.073s
ok compress/lzw 0.548s
ok compress/zlib 7.406s
ok container/heap 0.039s
ok container/list 0.038s
ok container/ring 0.098s
? crypto [no test files]
ok crypto/aes 0.137s
ok crypto/cipher 0.059s
ok crypto/des 0.238s
ok crypto/dsa 0.092s
ok crypto/ecdsa 0.237s
ok crypto/elliptic 0.096s
ok crypto/hmac 0.049s
ok crypto/md5 0.048s
ok crypto/rand 0.194s
ok crypto/rc4 0.035s
ok crypto/rsa 1.049s
ok crypto/sha1 0.053s
ok crypto/sha256 0.044s
ok crypto/sha512 0.063s
ok crypto/subtle 0.060s
ok crypto/tls 2.910s
ok crypto/x509 6.943s
? crypto/x509/pkix [no test files]
ok database/sql 0.092s
ok database/sql/driver 0.040s
ok debug/dwarf 0.064s
ok debug/elf 0.107s
ok debug/gosym 0.047s
ok debug/macho 0.053s
ok debug/pe 0.061s
ok encoding/ascii85 0.055s
ok encoding/asn1 0.061s
ok encoding/base32 0.045s
ok encoding/base64 0.061s
ok encoding/binary 0.060s
ok encoding/csv 0.052s
ok encoding/gob 0.222s
ok encoding/hex 0.040s
ok encoding/json 0.282s
ok encoding/pem 0.071s
ok encoding/xml 0.094s
ok errors 0.043s
ok exp/cookiejar 0.080s
ok exp/ebnf 0.051s
ok exp/ebnflint 0.056s
ok exp/gotype 11.357s
ok exp/html 0.811s
ok exp/html/atom 0.038s
ok exp/inotify 1.371s
ok exp/locale/collate 0.152s
ok exp/locale/collate/build 0.067s
? exp/locale/collate/tools/colcmp [no test files]
ok exp/norm 7.399s
ok exp/utf8string 0.038s
ok expvar 0.065s
ok flag 0.038s
ok fmt 0.267s
ok go/ast 0.070s
ok go/build 0.636s
ok go/doc 0.326s
ok go/format 0.095s
ok go/parser 0.258s
ok go/printer 2.172s
ok go/scanner 0.070s
ok go/token 0.267s
ok go/types 2.003s
? hash [no test files]
ok hash/adler32 0.114s
ok hash/crc32 0.039s
ok hash/crc64 0.049s
ok hash/fnv 0.039s
ok html 0.045s
ok html/template 0.266s
ok image 0.495s
ok image/color 0.073s
ok image/draw 0.161s
? image/gif [no test files]
ok image/jpeg 0.665s
ok image/png 0.324s
ok index/suffixarray 0.078s
ok io 0.069s
ok io/ioutil 0.051s
ok log 0.060s
ok log/syslog 0.456s
ok math 0.057s
ok math/big 2.245s
ok math/cmplx 0.039s
ok math/rand 0.151s
ok mime 0.043s
ok mime/multipart 0.648s
ok net 2.929s
ok net/http 12.728s
ok net/http/cgi 1.228s
ok net/http/fcgi 0.073s
ok net/http/httptest 0.082s
ok net/http/httputil 0.150s
? net/http/pprof [no test files]
ok net/mail 0.072s
ok net/rpc 0.332s
ok net/rpc/jsonrpc 0.090s
ok net/smtp 0.074s
ok net/textproto 0.057s
ok net/url 0.069s
ok old/netchan 0.111s
ok os 0.184s
ok os/exec 2.086s
ok os/signal 0.149s
ok os/user 0.050s
ok path 0.045s
ok path/filepath 0.792s
ok reflect 0.163s
ok regexp 0.596s
ok regexp/syntax 3.100s
ok runtime 6.031s
? runtime/cgo [no test files]
ok runtime/debug 0.048s
ok runtime/pprof 1.291s
ok sort 0.447s
ok strconv 2.540s
ok strings 0.676s
ok sync 0.320s
ok sync/atomic 0.523s
ok syscall 0.099s
? testing [no test files]
? testing/iotest [no test files]
ok testing/quick 0.139s
ok text/scanner 0.059s
ok text/tabwriter 0.049s
ok text/template 0.134s
ok text/template/parse 0.076s
--- FAIL: TestReset (0.15 seconds)
sleep_test.go:254: resetting unfired timer returned false
FAIL
FAIL time 4.136s
ok unicode 0.043s
ok unicode/utf16 0.039s
ok unicode/utf8 0.064s
? unsafe [no test files]

Dave Cheney

unread,
Jan 22, 2013, 6:44:16 PM1/22/13
to golan...@googlegroups.com
Not really, but I'm getting tired of this error

https://code.google.com/p/go/issues/detail?id=4690
Reply all
Reply to author
Forward
0 new messages