Is it possible to open a cherry-pick CL via a GitHub pull request?

[ma...@influxdata.com]

https://github.com/golang/go/issues/27398 is a backport to Go 1.11 issue for a change I originally submitted as a GitHub pull request.

The comment from Gopherbot links to https://github.com/golang/go/wiki/MinorReleases#making-cherry-pick-cls, which says I have to go through Gerrit, but it doesn't say I can't submit a PR against the release-branch.go1.11 branch.

I thought I'd ask here before trying to open a PR.

If the answer is that you must go through Gerrit, then I would appreciate if anyone else would submit the cherry-pick CL for me. The SHA of the original commit is 014901c5bab2f99af3b1019d5776fa5da6f5bef7. Thanks.

[Ian Lance Taylor]

We use gerritbot to convert all GitHub pull requests to Gerrit
changes. In this case the Gerrit change is
https://golang.org/cl/132116. So we can cherry pick that.

Ian

[Ian Lance Taylor]

Cherry picked as https://golang.org/cl/139421 .

Ian

[dmit...@golang.org]

Hello,

I've looked into the original question of whether it's possible to open a cherry-pick CL via a GitHub pull request.

It isn't possible at this time. I've opened issue golang.org/issue/30037 to track what needs to be resolved in order for it to become possible. Until then, only Gerrit is supported.

I've also added a note about this to the MinorReleases wiki page (last paragraph in that section).

Thanks.

[Mark Rushakoff]

Dmitri, thanks for taking ownership of all these tooling issues. I keep up regularly with golang-dev and the Go issues on GitHub, and it's great to see these "small" details getting attention.

--
You received this message because you are subscribed to a topic in the Google Groups "golang-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/golang-dev/Tc8OlLRsju0/unsubscribe.
To unsubscribe from this group and all its topics, send an email to golang-dev+...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.