this branch is never reachable or just need a test case?

[xie cui]

https://github.com/cuiweixie/go/blob/useless/src/cmd/compile/internal/types2/unify.go#L318-L319

I add these two line, then run ./all.bash in src. all test passed.

I think this branch it's unneccessary.  but I am not very sure. maybe we just need a test to cover it.

[Robert Griesemer]

Please leave this alone. We may need this branch with better type inference. Thanks.

- gri

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/7c836474-70a2-48c5-80f0-d6d7d186f56cn%40googlegroups.com.

[xie cui]

can you provide some code  that reachable this branch, I can not come up with a code.

[Robert Griesemer]

This will start to happen once https://go-review.git.corp.google.com/c/go/+/483935 is submitted.

- gri

To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/bba64032-7fbc-4975-92b3-826bb4a5b69fn%40googlegroups.com.