code review 12603044: encoding/xml: add, support Marshaler interface (issue 12603044)

[r...@golang.org]

Reviewers: golang-dev1,

Message:
Hello golan...@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/


Description:
encoding/xml: add, support Marshaler interface

See golang.org/s/go12xml for design.

Please review this at https://codereview.appspot.com/12603044/

Affected files:
M src/pkg/encoding/xml/marshal.go
M src/pkg/encoding/xml/marshal_test.go

[ia...@golang.org]

https://codereview.appspot.com/12603044/diff/5001/src/pkg/encoding/xml/marshal.go
File src/pkg/encoding/xml/marshal.go (right):

https://codereview.appspot.com/12603044/diff/5001/src/pkg/encoding/xml/marshal.go#newcode89
src/pkg/encoding/xml/marshal.go:89: // to encode it uses
e.EncodeElement.
s/uses/using/

https://codereview.appspot.com/12603044/diff/5001/src/pkg/encoding/xml/marshal.go#newcode98
src/pkg/encoding/xml/marshal.go:98: // Marshaler is the interface
implemented by objects that can marshal
s/Marshaler/MarshalerAttr/

https://codereview.appspot.com/12603044/diff/5001/src/pkg/encoding/xml/marshal.go#newcode101
src/pkg/encoding/xml/marshal.go:101: // MarshalXMLAttr encodes the
receiver as an XML attribute.
How about something more like
MarshalXMLAttr returns an XML attribute with the encoded value of the
receiver.

https://codereview.appspot.com/12603044/

[Russ Cox]

Done.

[r...@golang.org]

Hello golan...@googlegroups.com, ia...@golang.org (cc:
golan...@googlegroups.com),

Please take another look.


https://codereview.appspot.com/12603044/

[dan.ko...@adelaide.edu.au]

LGTM

https://codereview.appspot.com/12603044/

[r...@golang.org]

*** Submitted as
https://code.google.com/p/go/source/detail?r=2ca230b93195 ***

encoding/xml: add, support Marshaler interface

See golang.org/s/go12xml for design.

Fixes issue 2771.
Fixes issue 4169.
Fixes issue 5975.
Fixes issue 6125.

R=golang-dev, iant, dan.kortschak
CC=golang-dev
https://codereview.appspot.com/12603044


https://codereview.appspot.com/12603044/

[Russ Cox]

I did not intend to submit this; I pasted the wrong CL number while trying to submit the encoding CL. I'm still happy to make changes to this code in follow-up CLs.

[Russ Cox]

I rolled this CL back. The new pending copy is https://codereview.appspot.com/12919043. Please leave comments there.