almost Go 1.5.2 in release-branch.go1.5

[Russ Cox]

I think we're close to done with Go 1.5.2. We have not done any of the formal release mechanism yet, nor do we have a promised date on which it will be out. But I believe the code in release-branch.go1.5 is the code that will be the release.

If you know of something we're missing or did wrong, please reply to this email thread. (Please do not file new Go 1.5.2 issues, to avoid confusion about what is and is not in the release.)

Thanks.

Russ

[Austin Clements]

https://go-review.googlesource.com/17193 runtime: improve stack barrier debugging

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Chris Broadfoot]

I'll hold off on cutting the release til 17193 is submitted.

[Austin Clements]

I would also like to get https://go-review.googlesource.com/#/c/17191 in, which actually fixes https://golang.org/issue/12932.

[Mark Pulford]

I've just noticed that the Setgid test updated in rev a897684 fails under the race detector. The previous rev builds and tests cleanly.

$ set | grep ^GO

GO15VENDOREXPERIMENT=

GOARCH=amd64

GOBIN=

GOEXE=

GOGCCFLAGS='-fPIC -m64 -pthread -fmessage-length=0'

GOHOSTARCH=amd64

GOHOSTOS=linux

GOOS=linux

GORACE=

GOROOT=/home/mark/go

GOTOOLDIR=/home/mark/go/pkg/tool/linux_amd64

$ which go

~/go/bin/go

$ go test -run Setgid

PASS

ok   _/home/mark/go/misc/cgo/test 0.002s

$ go test -race -run Setgid

--- FAIL: TestSetgid (5.00s)

setgid_linux.go:47: setgid hung after signal.Notify

FAIL

exit status 1

FAIL _/home/mark/go/misc/cgo/test 5.007s

I haven't investigated further.

[Russ Cox]

On Mon, Nov 23, 2015 at 7:18 PM, Chris Broadfoot <cb...@golang.org> wrote:

I'll hold off on cutting the release til 17193 is submitted.

Thanks. Let's actually just wait at least until next week. I don't feel good about where we are right now. It feels a little too rushed due to the holiday, and rushed never ends well.

Russ

[Chris Broadfoot]

Sounds good to me. I agree, there's no need to rush 1.5.2 through.

[Ian Lance Taylor]

I can't recreate this, either on tip or on 1.5 branch. Is this
repeatable for you?

(This is not in itself a reason to hold up the 1.5 release; I'm
confident that the new test would fail with 1.5.1 with or without
-race.)

Ian

[Mark Pulford]

On Tue, Nov 24, 2015 at 10:53:05AM -0800, Ian Lance Taylor wrote:
> I can't recreate this, either on tip or on 1.5 branch. Is this
> repeatable for you?

I found the problem.. I was relying on all.bash to clear out the pkg
directory between builds.

setup() in cmd/dist/build.go removes pkg/OS_ARCH but leaves
pkg/OS_ARCH_race in place.

Regards,
Mark

[Russ Cox]

Great, thanks. That's fixed for Go 1.6.

Russ