Please switch to LUCI for basic presubmit testing

[Heschi Kreinick]

As of this week, we’re ready to switch basic presubmit testing from the old system to LUCI.

What you should do:

Instead of voting Run-TryBot+1 to test your CLs, vote Commit-Queue+1. (We’ve updated the -trybot flag of git-codereview to do this as well; run go install golang.org/x/review/git-codereview@latest to pick it up.) As before, a comment will be posted to the CL to confirm that the CL is being tested, and once the run finishes. Status and results will appear in chips just below the CL description:

In most cases, you’ll be able to see the details of failing tests directly from the Checks tab in Gerrit:

You can also look at the Test Results tab of the build after you click through to it.

However, the go command does not yet report structured build errors. If your build fails, you’ll need to look into the build or test shard that failed by clicking the link in the failed step:

Once you click through, the failing step will be highlighted in red, and the command’s output will show the build failure as usual.

For more details, see the wiki for TryBots and SlowBots.

There are a few outstanding known issues:

• We’ve only migrated a small set of builders, mostly those needed for presubmit testing plus longtest builds. If you need a SlowBot run for another builder, you’ll need to use the old Run-Trybots+1 vote with a TRY= comment as before.
• may-start-trybots only grants permission to run presubmits on your own CLs. (Approvers can still trigger them on anything, as before.) If that causes a problem for you, please comment or react on our issue and we’ll consider prioritizing the fix or a workaround.
• Those who rely on Gerrit’s Attention Set feature may notice that LUCI brings your CLs to your attention when it’s not totally appropriate.

For any feedback, please reply to this thread or file an issue with an “x/build:” prefix. We want this to be an improvement in your development experience, and we appreciate you letting us know where the rough spots are.

Thanks,

Heschi for the Go Release Team

[Daniel Martí]

Hi there,

I was wondering how the rollout to this new trybot system is going - I see that the legacy trybots are still around and can still be triggered, but I assume that we should continue to trigger the new ones per your email.

Also, somewhat related: how did you arrive at the name Commit-Queue for the new vote? My mind goes to "queue this commit for submiting when all conditions are met", but what actually does that is Auto-Submit :)

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/CAAnZ_2422kziFP-uJ-uYbbptyK77xcrjJct7D6Fr9VHKuX%2Ba7w%40mail.gmail.com.

[Jorropo]

I continue to use trybots when I want to run CI on someone else's CL.

https://github.com/golang/go/issues/62332

To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/da046808-ed61-4cbf-afa1-50c90b260e76%40mvdan.cc.

[Michael Knyszek]

On Tue, Jan 16, 2024 at 4:30 AM 'Daniel Martí' via golang-dev <golan...@googlegroups.com> wrote:

Hi there,

I was wondering how the rollout to this new trybot system is going - I see that the legacy trybots are still around and can still be triggered, but I assume that we should continue to trigger the new ones per your email.

Yes please, where possible! Thanks. If you encounter any issues or friction, please file an issue on GitHub.

The rollout is progressing as we port more of our builders in postsubmit to LUCI. We're nearing completion for first class ports with a bunch of non-first-class ports already moved over. We're also busy porting over other parts of our infrastructure, like watchflakes, gomote, the performance dashboard, etc.

At least for ports and builders, you can see the current progress here: https://ci.chromium.org/p/golang, or scattered about a bunch of GitHub issues. Apologies for the lack of update here; we'll have more as we approach completion.

Also, somewhat related: how did you arrive at the name Commit-Queue for the new vote? My mind goes to "queue this commit for submiting when all conditions are met", but what actually does that is Auto-Submit :)

Yeah, that name is historical to LUCI and can't be changed for the time being. We're also currently only using CQ+1, which is intended for "dry runs." We hope to migrate to replacing the submit button in Gerrit with CQ+2 in the future (which we've disabled for now) that'll re-run tests before submission with your CLs rebased on tip-of-tree. We also hope it can become a replacement for Auto-Submit+1 after some additional work.

I can file a GitHub issue to track this so that the future trajectory is clearer.

 

To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/da046808-ed61-4cbf-afa1-50c90b260e76%40mvdan.cc.

[Daniel Martí]

Makes much more sense with the context you provided, thanks!

Indeed a tracking issue would be great, then anyone interested like myself can subscribe. I think sending updates here would be fine too for what it's worth, but perhaps an issue is easier in terms of your project management.

The long term vision to use a single label with +1 and +2 states seems reasonable too. Easier to remember than three labels, for sure :)

Just one FYI: the ci.chromium.org link just says "We couldn't find the page you were looking for" for me, even after logging in.

[Michael Knyszek]

On Tue, Jan 16, 2024 at 12:06 PM Daniel Martí <mv...@mvdan.cc> wrote:

Makes much more sense with the context you provided, thanks!

Indeed a tracking issue would be great, then anyone interested like myself can subscribe. I think sending updates here would be fine too for what it's worth, but perhaps an issue is easier in terms of your project management.

The long term vision to use a single label with +1 and +2 states seems reasonable too. Easier to remember than three labels, for sure :)

Just one FYI: the ci.chromium.org link just says "We couldn't find the page you were looking for" for me, even after logging in.

Huh. We may have just missed an ACL; all the builds should already be public. I'll take a look, thanks.

[Michael Knyszek]

On Tue, Jan 16, 2024 at 12:11 PM Michael Knyszek <mkny...@google.com> wrote:

On Tue, Jan 16, 2024 at 12:06 PM Daniel Martí <mv...@mvdan.cc> wrote:

Makes much more sense with the context you provided, thanks!

Indeed a tracking issue would be great, then anyone interested like myself can subscribe. I think sending updates here would be fine too for what it's worth, but perhaps an issue is easier in terms of your project management.

The long term vision to use a single label with +1 and +2 states seems reasonable too. Easier to remember than three labels, for sure :)

Just one FYI: the ci.chromium.org link just says "We couldn't find the page you were looking for" for me, even after logging in.

Huh. We may have just missed an ACL; all the builds should already be public. I'll take a look, thanks.

Hey Daniel, a few of us have tried from personal accounts and/or incognito mode and https://ci.chromium.org/p/golang appears to be publicly accessible to us (even without login). If you're still encountering issues, do you mind filing a GitHub issue? Thanks.

[Daniel Martí]

It works for me now as well, so all good :) Not sure what happened or if it got fixed.

[Meng Zhuo]

Hi, Go team

I have "+1 TryBot" access and trying to use "Commit Queue", but it failed with "CV cannot start a Run for mzh@* because the user is not a dry-runner."

Do I need to reapply "commit queue"  permission? Thanks

https://go-review.googlesource.com/c/go/+/514775

[Dmitri Shuralyov]

Hi Meng,

You already have approvers access, but it's currently granted to an older email,

the one you used before go.dev/cl/374494.

It seems CV requires your primary Gerrit email address to match exactly.

Please file an access issue, we'll use it to update to your new email, which should fix this.

Thanks,

Dmitri

[Michael Pratt]

FYI, thus far people with "may-start-trybots" (permission to start trybots) have only been able to trigger LUCI tests on their own CLs, and would receive an error if they attempted to start trybots on someone else's CL. This has been resolved, so "may-start-trybots" contributors should be able trigger LUCI trybots on all of the same CLs that approvers can. If you encounter more issues triggering trybots, please report here or on https://go.dev/issue/62332.

(Note that there is an additional known issue, https://go.dev/cl/65140, that no one can trigger trybots on children CLs of a CL stack sent by an unprivileged contributor.)

--

You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/1d8d16f0-0233-44ca-870c-a8c6146fe38an%40googlegroups.com.

[Dan Kortschak]

On Thu, 2024-02-01 at 16:28 -0500, 'Michael Pratt' via golang-dev
wrote:

> FYI, thus far people with "may-start-trybots" (permission to start
> trybots) have only been able to trigger LUCI tests on their own CLs,
> and would receive an error if they attempted to start trybots on
> someone else's CL. This has been resolved, so "may-start-trybots"
> contributors should be able trigger LUCI trybots on all of the same
> CLs that approvers can. If you encounter more issues triggering
> trybots, please report here or on https://go.dev/issue/62332.
>

Can I get a clarification on whether I should expect to be able to run
tests on this CL https://go-review.googlesource.com/c/tools/+/562575

I am the author and have Run-TryBot.

thanks
Dan

[Michael Pratt]

Hi Dan,

Yes you should be able to run tests. It looks like our ACL list had the wrong email address for you. I've updated it to the email on https://go.dev/issue/52246 (same as on Gerrit), so it should work now.

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/2be7bdf839554577265bd0b6c8aa697ca6132b90.camel%40kortschak.io.

[Joel Sing]

I appear to be hitting similar access issues:

  https://go-review.googlesource.com/c/review/+/543495

[Dmitri Shuralyov]

Joel, it should be fixed for your account now.

[Joel Sing]

A belated thanks - I can successfully kick off LUCI trybots, however trying to "Choose trybots", clicking add results in:

"Failed to create builds. Please try again. See console logs, too."

[Dmitri Shuralyov]

Joel, your Gerrit account is likely running into the same problem as in go.dev/issue/67468, where a different email is used for the Choose trybots dialog compared to the Gerrit Commit-Queue+1 vote. Your primary Gerrit email remains as is so that your CR+2/Commit-Queue+1 votes keep working, and I've temporarily re-added your previous email to may-start-trybots while we look into this. Please comment on that issue with more details if it still doesn't work.