Re: code review 6218048: doc/progs: use test/run.go for testing (issue 6218048)

[r...@golang.org]

LGTM but you need a change to run.bash


http://codereview.appspot.com/6218048/

[minu...@gmail.com]

On 2012/08/30 14:43:17, rsc wrote:
> ... but you need a change to run.bash
run.go can't test cgo*.go and go1.go now
can we just add
go run %GOROOT%/test/run.go - ../doc/progs
to run.bash without deleting the existing call to
../doc/prog.run?

http://codereview.appspot.com/6218048/

[Russ Cox]

On Sat, Sep 1, 2012 at 4:16 AM, <minu...@gmail.com> wrote:
> On 2012/08/30 14:43:17, rsc wrote:
>>
>> ... but you need a change to run.bash
>
> run.go can't test cgo*.go and go1.go now
> can we just add
> go run %GOROOT%/test/run.go - ../doc/progs
> to run.bash without deleting the existing call to
> ../doc/prog.run?

I guess so, but I would rather keep run.bat and run.bash in sync. It
sounds like you are saying that even after this CL the Windows build
is missing some tests that happen in the Unix build?

Russ

[minux]

On Sat, Sep 1, 2012 at 9:55 PM, Russ Cox <r...@golang.org> wrote:

I guess so, but I would rather keep run.bat and run.bash in sync. It

sounds like you are saying that even after this CL the Windows build
is missing some tests that happen in the Unix build?

cgo[1-4].go can only be tested on cgo enabled (and not FreeBSD)

builds, our run.go doesn't support conditional testing.

go1.go will output filenames in the current directory, so this can'be

tested by "cmpout"/"run", so i can only "compile" this file (unless run.go

supports regexp matching for cmpout)

[Russ Cox]

ok

[minu...@gmail.com]

*** Submitted as
http://code.google.com/p/go/source/detail?r=2323dc1ecb83 ***

doc/progs: use test/run.go for testing on Windows
cgo[1-4].go, go1.go couldn't be tested now
(cgo[1-4].go can only be tested when cgo is enabled, go1.go
contain a list of filenames in the current directory)

R=golang-dev, alex.brainman, rsc
CC=golang-dev
http://codereview.appspot.com/6218048


http://codereview.appspot.com/6218048/