code review 9777043: ssh/terminal: support home, end, up and down keys. (issue 9777043)

38 views
Skip to first unread message

a...@golang.org

unread,
May 25, 2013, 3:09:37 PM5/25/13
to golan...@googlegroups.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: golang-dev1,

Message:
Hello golan...@googlegroups.com (cc: golan...@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto/


Description:
ssh/terminal: support home, end, up and down keys.

Please review this at https://codereview.appspot.com/9777043/

Affected files:
M ssh/terminal/terminal.go


Dave Cheney

unread,
May 28, 2013, 8:40:58 AM5/28/13
to Adam Langley, golang-dev, re...@codereview-hr.appspotmail.com
LGTM, but I feel uncomfortable without a test.
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
Reply all
Reply to author
Forward
0 new messages