Need +2 & +1s on trivial fix for serious bug

[Jorropo]

Hello I have https://go-review.googlesource.com/c/go/+/747664 which has been open for some amount of time.

It's a really trivial fix for a bug reported by multiple persons that makes go programs unusable on 32 bits mips processors running a kernel <5.1.

The original reporter confirmed the CL fixes their problem.

You can +2 this CL without having the hardware or running the patch by taking a look at the linux ENOSYS definitions:

https://elixir.bootlin.com/linux/v6.19.3/A/ident/ENOSYS

If you follow the mips definition you get:

https://elixir.bootlin.com/linux/v6.19.3/source/arch/mips/include/uapi/asm/errno.h#L64

With 1.26.1 tomorrow, the original reporter asked where the status of this fix was.

Thanks

[Michael Pratt]

IIUC, https://go.dev/cl/747663 is no longer sufficient because even though it fixes most mips builds, it breaks on Synology devices? I guess that is better than the status quo, but not great.

I agree that this won't make 1.26.1. As a rule of thumb, if a cherry pick isn't approved by Friday on the week before a minor release, then it's safe to say it won't make it into the release.

That said, it does feel like we need some mechanism to make sure that cherry picks waiting on upstream CL review actually get looked at.

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/golang-dev/CAHWihb9frRudX0e9D1k2%3D5Eo-oBDdo7c%2BH%2B%3D0oHW%3DXwFuVwFSw%40mail.gmail.com.

[Jorropo]

Thanks for taking a look, yeah the Synology bug is completely unrelated and due to incompatibilities on an OS we do not support,
I'm not sure if we should even backport it (it would be rude for the users running these NASes but the Synology engineers really dropped the ball on that one).