Re: code review 5966067: runtime: give proper messages when user defined DYLD_IN... (issue 5966067)

13 views
Skip to first unread message

minu...@gmail.com

unread,
Apr 25, 2012, 1:51:57 AM4/25/12
to r...@golang.org, kra...@gmail.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
Hello r...@golang.org, kra...@gmail.com (cc:
golan...@googlegroups.com),

Please take another look.


http://codereview.appspot.com/5966067/

r...@golang.org

unread,
Apr 30, 2012, 3:55:30 PM4/30/12
to minu...@gmail.com, kra...@gmail.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
*** Submitted as
http://code.google.com/p/go/source/detail?r=09fe7345e11d ***

runtime: give proper messages when user defined DYLD_INSERT_LIBRARIES on
Darwin
also gives clear error when bsdthread_register fails on Darwin
Fixes issue 2992.

R=rsc, krautz
CC=golang-dev
http://codereview.appspot.com/5966067

Committer: Russ Cox <r...@golang.org>


http://codereview.appspot.com/5966067/

Russ Cox

unread,
Apr 30, 2012, 3:55:18 PM4/30/12
to minu...@gmail.com, r...@golang.org, kra...@gmail.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
LGTM
Reply all
Reply to author
Forward
0 new messages