code review 10229043: runtime: fix plan9, windows builds (issue 10229043)

[r...@golang.org]

Reviewers: dvyukov,

Message:
Hello dvyukov (cc: golan...@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/


Description:
runtime: fix plan9, windows builds

Please review this at https://codereview.appspot.com/10229043/

Affected files:
M src/pkg/runtime/os_plan9_386.c
M src/pkg/runtime/os_plan9_amd64.c
M src/pkg/runtime/os_windows_386.c
M src/pkg/runtime/os_windows_amd64.c


Index: src/pkg/runtime/os_plan9_386.c
===================================================================
--- a/src/pkg/runtime/os_plan9_386.c
+++ b/src/pkg/runtime/os_plan9_386.c
@@ -95,7 +95,7 @@
runtime·printf("\n");

if(runtime·gotraceback(&crash)) {
- runtime·traceback((void*)ureg->pc, (void*)ureg->sp, 0, gp);
+ runtime·traceback(ureg->pc, ureg->sp, 0, gp);
runtime·tracebackothers(gp);
runtime·dumpregs(ureg);
}
Index: src/pkg/runtime/os_plan9_amd64.c
===================================================================
--- a/src/pkg/runtime/os_plan9_amd64.c
+++ b/src/pkg/runtime/os_plan9_amd64.c
@@ -103,7 +103,7 @@
runtime·printf("\n");

if(runtime·gotraceback(&crash)) {
- runtime·traceback((void*)ureg->ip, (void*)ureg->sp, 0, gp);
+ runtime·traceback(ureg->ip, ureg->sp, 0, gp);
runtime·tracebackothers(gp);
runtime·dumpregs(ureg);
}
Index: src/pkg/runtime/os_windows_386.c
===================================================================
--- a/src/pkg/runtime/os_windows_386.c
+++ b/src/pkg/runtime/os_windows_386.c
@@ -76,7 +76,7 @@
runtime·printf("\n");

if(runtime·gotraceback(&crash)){
- runtime·traceback((void*)r->Eip, (void*)r->Esp, 0, gp);
+ runtime·traceback(r->Eip, r->Esp, 0, gp);
runtime·tracebackothers(gp);
runtime·dumpregs(r);
}
Index: src/pkg/runtime/os_windows_amd64.c
===================================================================
--- a/src/pkg/runtime/os_windows_amd64.c
+++ b/src/pkg/runtime/os_windows_amd64.c
@@ -83,7 +83,7 @@
runtime·printf("\n");

if(runtime·gotraceback(&crash)){
- runtime·traceback((void*)r->Rip, (void*)r->Rsp, 0, gp);
+ runtime·traceback(r->Rip, r->Rsp, 0, gp);
runtime·tracebackothers(gp);
runtime·dumpregs(r);
}

[r...@golang.org]

*** Submitted as
https://code.google.com/p/go/source/detail?r=c855ffd64015 ***

runtime: fix plan9, windows builds

TBR=dvyukov
CC=golang-dev
https://codereview.appspot.com/10229043


https://codereview.appspot.com/10229043/

[dvy...@google.com]

LGTM

https://codereview.appspot.com/10229043/