Re: code review 5869049: test: use testlib in a few more cases (part 2) (issue 5869049)
16 views
Skip to first unread message
minu...@gmail.com
Apr 19, 2012, 12:46:29 PM4/19/12
to golan...@googlegroups.com, ia...@golang.org, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
Brad Fitzpatrick
Apr 19, 2012, 12:49:33 PM4/19/12
to minu...@gmail.com, golan...@googlegroups.com, ia...@golang.org, re...@codereview-hr.appspotmail.com
What is "run|run"? Or is it "run|run -"? All the other ones have obvious names like "build", "compile", "run".
Can you find a better name, or at least write some comments?
On Thu, Apr 19, 2012 at 9:46 AM, <minu...@gmail.com> wrote:
ping.
http://codereview.appspot.com/5869049/
minu...@gmail.com
Apr 19, 2012, 12:53:24 PM4/19/12
to golan...@googlegroups.com, ia...@golang.org, brad...@golang.org, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
On 2012/04/19 16:49:39, bradfitz wrote:
> What is "run|run"? Or is it "run|run -"? All the other ones have
obvious
> names like "build", "compile", "run".
run|run means this run this tests and treat the output as a new go> What is "run|run"? Or is it "run|run -"? All the other ones have
obvious
> names like "build", "compile", "run".
program, and run it (a normal shell pipeline).
run|run - is just for the testlib.
Of course, if you want a new command, I'm glad to do so.
ia...@golang.org
Apr 19, 2012, 4:22:47 PM4/19/12
to minu...@gmail.com, golan...@googlegroups.com, brad...@golang.org, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
Personally I would prefer to see a clearer single name rather than go
back to shell syntax.
back to shell syntax.
minux
Apr 19, 2012, 4:45:39 PM4/19/12
to minu...@gmail.com, golan...@googlegroups.com, ia...@golang.org, brad...@golang.org, re...@codereview-hr.appspotmail.com
On Fri, Apr 20, 2012 at 4:22 AM, <ia...@golang.org> wrote:
Personally I would prefer to see a clearer single name rather than go
back to shell syntax.
how about runGenerated? I used 'run|run' because I didn't know any better name...
so any suggestions welcome.
ia...@golang.org
Apr 19, 2012, 5:07:00 PM4/19/12
to minu...@gmail.com, golan...@googlegroups.com, brad...@golang.org, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
Oh, you want suggestions.... I'm terrible at names. How about just
"runrun"?
"runrun"?
remyoud...@gmail.com
Apr 19, 2012, 7:17:14 PM4/19/12
to minu...@gmail.com, golan...@googlegroups.com, ia...@golang.org, brad...@golang.org, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
I suggest "runoutput".
Brad Fitzpatrick
Apr 19, 2012, 7:22:06 PM4/19/12
to minu...@gmail.com, golan...@googlegroups.com, ia...@golang.org, brad...@golang.org, remyoud...@gmail.com, re...@codereview-hr.appspotmail.com
SGTM
minu...@gmail.com
Apr 20, 2012, 8:08:40 AM4/20/12
to golan...@googlegroups.com, ia...@golang.org, brad...@golang.org, remyoud...@gmail.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
Brad Fitzpatrick
Apr 20, 2012, 11:26:55 AM4/20/12
to minu...@gmail.com, golan...@googlegroups.com, ia...@golang.org, brad...@golang.org, remyoud...@gmail.com, re...@codereview-hr.appspotmail.com
LGTM
On Fri, Apr 20, 2012 at 5:08 AM, <minu...@gmail.com> wrote:
PTAL.
http://codereview.appspot.com/5869049/
ia...@golang.org
Apr 20, 2012, 11:44:39 AM4/20/12
to minu...@gmail.com, golan...@googlegroups.com, brad...@golang.org, remyoud...@gmail.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
minu...@gmail.com
Apr 20, 2012, 11:46:00 AM4/20/12
to minu...@gmail.com, golan...@googlegroups.com, ia...@golang.org, brad...@golang.org, remyoud...@gmail.com, re...@codereview-hr.appspotmail.com
*** Submitted as
http://code.google.com/p/go/source/detail?r=952bd8dc8259 ***
http://code.google.com/p/go/source/detail?r=952bd8dc8259 ***
test: use testlib in a few more cases (part 2)
Introduced "runoutput" cmd for running generated program
R=golang-dev, iant, bradfitz, remyoudompheng
CC=golang-dev
http://codereview.appspot.com/5869049
Reply all
Reply to author
Forward
0 new messages