Re: code review 5847068: misc/cgo/stdio: make it work on Windows (issue 5847068)

32 views
Skip to first unread message

minu...@gmail.com

unread,
Apr 25, 2012, 4:40:24 AM4/25/12
to alex.b...@gmail.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
any more thoughts on how to do tests on Windows?
should I just write a small diff like utility in misc/tools/ or I
write a test.go for each test that require output validation?


http://codereview.appspot.com/5847068/

Russ Cox

unread,
May 3, 2012, 5:49:16 PM5/3/12
to minu...@gmail.com, alex.b...@gmail.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
On Wed, Apr 25, 2012 at 4:40 AM, <minu...@gmail.com> wrote:
> any more thoughts on how to do tests on Windows?
> should I just write a small diff like utility in misc/tools/ or I
> write a test.go for each test that require output validation?

You could use 'fc', which is Windows's cmp.
http://ss64.com/nt/fc.html

Russ

minu...@gmail.com

unread,
May 11, 2012, 2:05:13 PM5/11/12
to alex.b...@gmail.com, r...@golang.org, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
PTAL.

If this approach is ok, I will try to enable other cgo tests on Windows.

http://codereview.appspot.com/5847068/

Russ Cox

unread,
May 16, 2012, 9:41:30 PM5/16/12
to minu...@gmail.com, alex.b...@gmail.com, r...@golang.org, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com
Can we reuse test/run.go?

minux

unread,
May 18, 2012, 12:24:55 PM5/18/12
to r...@golang.org, alex.b...@gmail.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com

On Thu, May 17, 2012 at 9:41 AM, Russ Cox <r...@golang.org> wrote:
Can we reuse test/run.go?
Sure. I've prepared two CLs to replace custom bash script under misc/cgo/* and doc/progs
CL 6220049 and CL 6218048.
Reply all
Reply to author
Forward
0 new messages