code review 6493113: html/template: fix URL doc (issue 6493113)

[r...@golang.org]

Reviewers: MikeSamuel,

Message:
Hello mikes...@gmail.com (cc: golan...@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
html/template: fix URL doc

This is the easy part of issue 3528.
(What to do about "noescape" is the hard part, left open.)

Update issue 3528.

Please review this at http://codereview.appspot.com/6493113/

Affected files:
M src/pkg/html/template/content.go


Index: src/pkg/html/template/content.go
===================================================================
--- a/src/pkg/html/template/content.go
+++ b/src/pkg/html/template/content.go
@@ -47,7 +47,7 @@
// JSStr("foo\\nbar") is fine, but JSStr("foo\\\nbar") is not.
JSStr string

- // URL encapsulates a known safe URL as defined in RFC 3896.
+ // URL encapsulates a known safe URL as defined in RFC 3896 or a URL
substring.
// A URL like `javascript:checkThatFormNotEditedBeforeLeavingPage()`
// from a trusted source should go in the page, but by default dynamic
// `javascript:` URLs are filtered out since they are a frequently

[Mike Samuel]

+1

2012/9/12 <r...@golang.org>:

[r...@golang.org]

LGTM

http://codereview.appspot.com/6493113/

[dsym...@golang.org]

LGTM


https://codereview.appspot.com/6493113/diff/5001/src/pkg/html/template/content.go
File src/pkg/html/template/content.go (right):

https://codereview.appspot.com/6493113/diff/5001/src/pkg/html/template/content.go#newcode50
src/pkg/html/template/content.go:50: // URL encapsulates a known safe

URL as defined in RFC 3896 or a URL substring.

s/ or/,&/

otherwise this can be parsed as "a URL substring" defining a known safe
URL.

https://codereview.appspot.com/6493113/

[Russ Cox]

> URL as defined in RFC 3896 or a URL substring.
> s/ or/,&/
>
> otherwise this can be parsed as "a URL substring" defining a known safe
> URL.

I used:

// URL encapsulates a known safe URL or URL substring (see RFC 3986).

[r...@golang.org]

*** Submitted as
http://code.google.com/p/go/source/detail?r=fead9e11a489 ***

html/template: fix URL doc

This is the easy part of issue 3528.
(What to do about "noescape" is the hard part, left open.)

Update issue 3528.

R=mikesamuel, r, dsymonds
CC=golang-dev
http://codereview.appspot.com/6493113


http://codereview.appspot.com/6493113/