Adding JSON output support to cmd/dist test

183 views
Skip to first unread message

Davis Goodin

unread,
May 7, 2021, 5:41:59 PM5/7/21
to golang-dev
Hi all,

I found https://github.com/golang/go/issues/37486, "cmd/dist: add json output support" after I (partially) implemented it while building and testing Go in an existing CI system. (If I pass "-json", the modified dist tool passes "-json" to the "go test" commands, but not all dist tests use "go test" so they don't output JSON.)

I was wondering if this issue is something that's being worked on, and if it would be useful if I submitted the partial implementation I've got. Or would it be better to wait for a full implementation that covers all tests before adding a "-json" flag to "dist test"?

I posted more details and my (small) commit last week at https://github.com/golang/go/issues/37486#issuecomment-830421349. I figured I should try asking golang-dev in case nobody's watching the issue anymore--it's been about a year since the last comment.

Thanks,
Davis

Davis Goodin

unread,
May 17, 2021, 11:54:58 AM5/17/21
to golang-dev
Hello again,

Any opinions on this change, is there prior work? Any objection to accepting a partial implementation of "-json" into "go tool dist test"?

If not, I'll go ahead and submit it to Gerrit for review soon.
Reply all
Reply to author
Forward
0 new messages